base: Fix an inefficiency in base::Pickle that caused extraneous allocations.

base: Fix an inefficiency in base::Pickle that caused extraneous allocations.

The Resize() method is supposed to be passed the size of the payload, not
including the header. In the copy constructor, it was being passed the size of
the payload plus the header.

BUG=
R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/f9ca8f5f0656036f8062be85a38b0f243bb0df34

[erikchen, 2015-09-08 22:04:14]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2015-09-08 22:04:14]

mark: Please review.

[Mark Mentovai, 2015-09-08 23:25:17]

LGTM

https://codereview.chromium.org/1327523006/diff/1/base/pickle.cc
File base/pickle.cc (right):

https://codereview.chromium.org/1327523006/diff/1/base/pickle.cc#newcode258
base/pickle.cc:258: size_t payload_size = header_size_ +
other.header_->payload_size;
This isn’t useful as a standalone variable now, you can do the addition right in
the memcpy() argument. (That’ll keep it more similar to operator=.)

[erikchen, 2015-09-08 23:33:39]

https://codereview.chromium.org/1327523006/diff/1/base/pickle.cc
File base/pickle.cc (right):

https://codereview.chromium.org/1327523006/diff/1/base/pickle.cc#newcode258
base/pickle.cc:258: size_t payload_size = header_size_ +
other.header_->payload_size;
On 2015/09/08 23:25:17, Mark Mentovai - August is over wrote:
> This isn’t useful as a standalone variable now, you can do the addition right
in
> the memcpy() argument. (That’ll keep it more similar to operator=.)

Done.

[erikchen, 2015-09-08 23:33:42]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-09-08 23:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1327523006/#ps20001
(title: "Comments from mark.")

[commit-bot: I haz the power, 2015-09-08 23:33:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327523006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327523006/20001

[erikchen, 2015-09-08 23:39:15]

Committed patchset #2 (id:20001) manually as
f9ca8f5f0656036f8062be85a38b0f243bb0df34 (presubmit successful).