base/pickle.h - Issue 1327523006: base: Fix an inefficiency in base::Pickle that caused extraneous allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/pickle.h

Issue 1327523006: base: Fix an inefficiency in base::Pickle that caused extraneous allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from mark. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/pickle.h

diff --git a/base/pickle.h b/base/pickle.h

index 40a983b80e046a7a625528c3de6ccf1dfd67faa4..b6ec116ebf68361fd4b3ab9e2f9110508e291bc2 100644

--- a/base/pickle.h

+++ b/base/pickle.h

@@ -296,6 +296,7 @@ class BASE_EXPORT Pickle {

}

inline void WriteBytesCommon(const void* data, size_t length);

+ FRIEND_TEST_ALL_PREFIXES(PickleTest, DeepCopyResize);

FRIEND_TEST_ALL_PREFIXES(PickleTest, Resize);

FRIEND_TEST_ALL_PREFIXES(PickleTest, FindNext);

FRIEND_TEST_ALL_PREFIXES(PickleTest, FindNextWithIncompleteHeader);

« no previous file with comments | « no previous file | base/pickle.cc » ('j') | no next file with comments »