base/pickle.cc - Issue 1327523006: base: Fix an inefficiency in base::Pickle that caused extraneous allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/pickle.cc

Issue 1327523006: base: Fix an inefficiency in base::Pickle that caused extraneous allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from mark. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/pickle.cc

diff --git a/base/pickle.cc b/base/pickle.cc

index d4487d45b24d61238309d3db48b1f17f4f2e0cca..7c8ffed4a266c270bf4256402312d353536157bf 100644

--- a/base/pickle.cc

+++ b/base/pickle.cc

@@ -254,9 +254,8 @@ Pickle::Pickle(const Pickle& other)

header_size_(other.header_size_),

capacity_after_header_(0),

write_offset_(other.write_offset_) {

- size_t payload_size = header_size_ + other.header_->payload_size;

- Resize(payload_size);

- memcpy(header_, other.header_, payload_size);

+ Resize(other.header_->payload_size);

+ memcpy(header_, other.header_, header_size_ + other.header_->payload_size);

}

Pickle::~Pickle() {

« no previous file with comments | « base/pickle.h ('k') | base/pickle_unittest.cc » ('j') | no next file with comments »