Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1327413003: [Ozone-DRM] Modeset when re-mapping windows to controllers (Closed)

Created:
5 years, 3 months ago by dnicoara
Modified:
5 years, 3 months ago
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org, dbehr
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-scanout2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRM] Modeset when re-mapping windows to controllers This fixes an issue where the surface associated with a window thinks it can submit a buffer, but the controller is waiting for a page flip event to finish. This issue is triggered in the following scenario: - surface1 mapped to display1 - surface2 mapped to display2 - surface2 page flips a buffer on display2 - surface1 is re-mapped to display2 - surface2 is re-mapped to display1 - surface1 had no pending buffers, so it thinks it is fine to schedule a page flip on display2 - display2 fails to page flip since it is still waiting for the callback from surface2 We had considered using a queue internally, though that would have complicated the logic. Since changing display configuration is a rare event we decided it would be simpler to just modeset at this point even if modesetting would take longer. BUG=511446, 529806 Committed: https://crrev.com/569ff0f367864bc65b8abaaab4dec1e57d25ac93 Cr-Commit-Position: refs/heads/master@{#348496}

Patch Set 1 #

Patch Set 2 : fixed unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M ui/ozone/platform/drm/gpu/drm_surface_unittest.cc View 1 4 chunks +23 lines, -21 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +13 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327413003/1
5 years, 3 months ago (2015-09-10 22:22:39 UTC) #2
dnicoara
This is required, but still doesn't fix the last corner case. I can still end ...
5 years, 3 months ago (2015-09-10 22:23:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/61395)
5 years, 3 months ago (2015-09-10 23:06:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327413003/20001
5 years, 3 months ago (2015-09-10 23:47:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 00:09:26 UTC) #10
alexst (slow to review)
lgtm
5 years, 3 months ago (2015-09-11 19:32:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327413003/20001
5 years, 3 months ago (2015-09-11 22:02:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 22:12:13 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/569ff0f367864bc65b8abaaab4dec1e57d25ac93 Cr-Commit-Position: refs/heads/master@{#348496}
5 years, 3 months ago (2015-09-11 22:12:49 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:26:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/569ff0f367864bc65b8abaaab4dec1e57d25ac93
Cr-Commit-Position: refs/heads/master@{#348496}

Powered by Google App Engine
This is Rietveld 408576698