Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1338843002: [Ozone-DRM] Use CRTC's mode when configuring it for mirror mode (Closed)

Created:
5 years, 3 months ago by dnicoara
Modified:
5 years, 3 months ago
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-scanout3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRM] Use CRTC's mode when configuring it for mirror mode Using the same mode on both CRTCs may not work if the timings are not correct. This patch configures the CRTC independently such that each one uses its own mode and timings. Also split modesetting from re-enabling so it is easier to reason when the CRTC's current mode can be reused. BUG=chrome-os-partner:42915 Committed: https://crrev.com/e342544e82671b42b94e1f2f6400ddb0a5c3b49a Cr-Commit-Position: refs/heads/master@{#348613}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Removed get_mode() from HDC per dbehr@'s comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -50 lines) Patch
M ui/ozone/platform/drm/gpu/drm_vsync_provider.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 2 3 chunks +17 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.h View 1 chunk +10 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 2 7 chunks +69 lines, -33 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (5 generated)
dnicoara
dbehr@ could you give this a try?
5 years, 3 months ago (2015-09-11 18:46:02 UTC) #2
alexst (slow to review)
lgtm
5 years, 3 months ago (2015-09-11 19:30:14 UTC) #3
dnicoara
On 2015/09/11 19:30:14, alexst wrote: > lgtm Could you take another look since I've removed ...
5 years, 3 months ago (2015-09-11 20:00:40 UTC) #4
dbehr
lgtm
5 years, 3 months ago (2015-09-11 21:20:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338843002/40001
5 years, 3 months ago (2015-09-11 22:00:46 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/53594)
5 years, 3 months ago (2015-09-12 01:27:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338843002/40001
5 years, 3 months ago (2015-09-14 14:07:34 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 14:26:37 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e342544e82671b42b94e1f2f6400ddb0a5c3b49a Cr-Commit-Position: refs/heads/master@{#348613}
5 years, 3 months ago (2015-09-14 14:27:21 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:32:17 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e342544e82671b42b94e1f2f6400ddb0a5c3b49a
Cr-Commit-Position: refs/heads/master@{#348613}

Powered by Google App Engine
This is Rietveld 408576698