Force swap buffers when re-creating the buffers

Force swap buffers when re-creating the buffers

The SwapResult provides a way to signal when the buffers are no longer
adequate and need to be re-allocated. Currently the surfaceless
implementation of the GpuBrowserCompositorOutputSurface will re-allocate
the buffers, however it doesn't swap again. Since the previous buffer
was rejected the display is showing an old frame.

BUG=511446
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/61df9d531b103895877d163c1635bac16d686952
Cr-Commit-Position: refs/heads/master@{#348246}

[dnicoara, 2015-09-10 19:07:26]

dnicoara@chromium.org changed reviewers:
+ jbauman@chromium.org

[dnicoara, 2015-09-10 19:07:27]

I'm not very familiar with the compositor code, so this is a naive approach to
fixing this issue.

I had tried doing this via the DisplayScheduler::ForceImmediateSwapIfPossible()
though that didn't seem to work for me. The current approach seems heavy handed
since it damages the whole surface while this operation may not need a full
damage (Really, this only needs to force a swap buffers).

Another option I was thinking of was using the
OutputSurfaceClient::SetNeedsRedrawRect() for this and just implement it in
cc::Display though I couldn't see what the "correct" way to implement it would
be.

Could you please provide some guidance on the correct way to do this?

[jbauman, 2015-09-10 19:29:50]

https://codereview.chromium.org/1327343003/diff/1/cc/output/output_surface_cl...
File cc/output/output_surface_client.h (right):

https://codereview.chromium.org/1327343003/diff/1/cc/output/output_surface_cl...
cc/output/output_surface_client.h:48: virtual void ForceSwap() = 0;
You should use SetNeedsRedrawRect, with a damage rect the size of the entire
surface. Then add your Display implementation there.

https://codereview.chromium.org/1327343003/diff/1/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/1327343003/diff/1/cc/surfaces/display.cc#newc...
cc/surfaces/display.cc:280:
aggregator_->SetFullDamageForSurface(current_surface_id_);
This won't actually force a swap immediately, it just ensures that the next time
there is a swap that it'll redraw the entire surface. You also need to do

if (scheduler_)
  scheduler_->SurfaceDamaged(current_surface_id_);

[dnicoara, 2015-09-10 19:39:39]

https://codereview.chromium.org/1327343003/diff/1/cc/output/output_surface_cl...
File cc/output/output_surface_client.h (right):

https://codereview.chromium.org/1327343003/diff/1/cc/output/output_surface_cl...
cc/output/output_surface_client.h:48: virtual void ForceSwap() = 0;
On 2015/09/10 19:29:49, jbauman wrote:
> You should use SetNeedsRedrawRect, with a damage rect the size of the entire
> surface. Then add your Display implementation there.

Done.

https://codereview.chromium.org/1327343003/diff/1/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/1327343003/diff/1/cc/surfaces/display.cc#newc...
cc/surfaces/display.cc:280:
aggregator_->SetFullDamageForSurface(current_surface_id_);
On 2015/09/10 19:29:50, jbauman wrote:
> This won't actually force a swap immediately, it just ensures that the next
time
> there is a swap that it'll redraw the entire surface. You also need to do
> 
> if (scheduler_)
>   scheduler_->SurfaceDamaged(current_surface_id_);

Done.

[jbauman, 2015-09-10 19:47:33]

lgtm

[dnicoara, 2015-09-10 19:51:24]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[dnicoara, 2015-09-10 19:51:42]

On 2015/09/10 19:47:33, jbauman wrote:
> lgtm

Thank you for the quick review!

[commit-bot: I haz the power, 2015-09-10 19:52:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327343003/20001

[commit-bot: I haz the power, 2015-09-10 21:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 21:05:10]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2015-09-10 21:29:39]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-09-10 21:31:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327343003/20001

[commit-bot: I haz the power, 2015-09-10 21:40:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-10 21:41:38]

Patchset 2 (id:??) landed as
https://crrev.com/61df9d531b103895877d163c1635bac16d686952
Cr-Commit-Position: refs/heads/master@{#348246}

[commit-bot: I haz the power, 2015-09-23 12:14:41]

Patchset 2 (id:??) landed as
https://crrev.com/61df9d531b103895877d163c1635bac16d686952
Cr-Commit-Position: refs/heads/master@{#348246}