Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1326763009: jni: Forbid inappropriate JNI parameter conversions. (Closed)

Created:
5 years, 3 months ago by Torne
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Forbid inappropriate JNI parameter conversions. Don't allow JavaParamRefs to be used to construct ScopedJavaLocalRefs. This leads to incorrect reference handling behaviour, since parameters are not allowed to be deleted. Instead code should simply pass the JavaParamRef by reference; functions should be taking "const JavaRef&" for input which is compatible. Fix the cases in the code where this conversion is currently being relied upon. BUG=506850 Committed: https://crrev.com/a8dd7a4e29d91d91c2b5e3e97062f5945737c050 Cr-Commit-Position: refs/heads/master@{#347923}

Patch Set 1 #

Patch Set 2 : Fix GN-only mojo, and chromecast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M base/android/scoped_java_ref.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/android/feedback/connectivity_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chromecast/browser/android/cast_window_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/android/cronet_library_loader.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/android/shell_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/android/javatests/mojo_test_case.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/android/main.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Torne
rmcilroy: general review, base/android/scoped_java_ref.h yfriedman: chrome/, content/ kelvinp: remoting/ mef: components/cronet/
5 years, 3 months ago (2015-09-04 12:52:38 UTC) #2
Torne
+gunsch: chromecast/ +sky: mojo/
5 years, 3 months ago (2015-09-04 14:02:02 UTC) #4
rmcilroy
lgtm.
5 years, 3 months ago (2015-09-04 14:06:23 UTC) #5
mef
components/cronet lgtm
5 years, 3 months ago (2015-09-04 14:15:22 UTC) #6
Yaron
lgtm
5 years, 3 months ago (2015-09-04 14:23:23 UTC) #7
sky
LGTM
5 years, 3 months ago (2015-09-04 15:00:46 UTC) #8
Torne
+lambroslambrou: remoting/ +halliwell: chromecast/
5 years, 3 months ago (2015-09-08 09:51:03 UTC) #10
gunsch
chromecast/ lgtm (sorry for delay, was out sick Friday, US holiday yesterday)
5 years, 3 months ago (2015-09-08 15:06:51 UTC) #11
Torne
On 2015/09/08 15:06:51, gunsch wrote: > chromecast/ lgtm > > (sorry for delay, was out ...
5 years, 3 months ago (2015-09-08 15:26:42 UTC) #12
Lambros
remoting/ lgtm
5 years, 3 months ago (2015-09-08 20:58:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326763009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326763009/20001
5 years, 3 months ago (2015-09-09 09:41:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 13:53:15 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 13:54:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8dd7a4e29d91d91c2b5e3e97062f5945737c050
Cr-Commit-Position: refs/heads/master@{#347923}

Powered by Google App Engine
This is Rietveld 408576698