chromecast/browser/android/cast_window_manager.cc - Issue 1326763009: jni: Forbid inappropriate JNI parameter conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/cast_window_manager.cc

Issue 1326763009: jni: Forbid inappropriate JNI parameter conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN-only mojo, and chromecast Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/website_preference_bridge.cc ('k') | components/cronet/android/cronet_library_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/cast_window_manager.cc

diff --git a/chromecast/browser/android/cast_window_manager.cc b/chromecast/browser/android/cast_window_manager.cc

index c4e2f1274eaf582c7b61d2bf4e5771bb192f56eb..7a0c51f609d05243d98455e67320fb586a485c1b 100644

--- a/chromecast/browser/android/cast_window_manager.cc

+++ b/chromecast/browser/android/cast_window_manager.cc

@@ -55,8 +55,7 @@ bool RegisterCastWindowManager(JNIEnv* env) {

void Init(JNIEnv* env,

const JavaParamRef<jclass>& clazz,

const JavaParamRef<jobject>& obj) {

- g_window_manager.Get().Reset(

- base::android::ScopedJavaLocalRef<jobject>(env, obj));

+ g_window_manager.Get().Reset(obj);

}

jlong LaunchCastWindow(JNIEnv* env,