content/shell/android/shell_manager.cc - Issue 1326763009: jni: Forbid inappropriate JNI parameter conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_manager.cc

Issue 1326763009: jni: Forbid inappropriate JNI parameter conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN-only mojo, and chromecast Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/android/shell_manager.cc

diff --git a/content/shell/android/shell_manager.cc b/content/shell/android/shell_manager.cc

index eb9e6368e601c2fffb3eed5ab15430c3f44c1ac7..f7cfd63b49fa75f1e6f1165e3a502040e88b03bd 100644

--- a/content/shell/android/shell_manager.cc

+++ b/content/shell/android/shell_manager.cc

@@ -52,8 +52,7 @@ bool RegisterShellManager(JNIEnv* env) {

static void Init(JNIEnv* env,

const JavaParamRef<jclass>& clazz,

const JavaParamRef<jobject>& obj) {

- g_global_state.Get().j_shell_manager.Reset(

- base::android::ScopedJavaLocalRef<jobject>(env, obj));

+ g_global_state.Get().j_shell_manager.Reset(obj);

}

void LaunchShell(JNIEnv* env,

« no previous file with comments | « components/cronet/android/cronet_library_loader.cc ('k') | mojo/android/javatests/mojo_test_case.cc » ('j') | no next file with comments »