Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1326763007: QUIC - Disable QUIC when there is bad packet loss rate (50% of the (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Disable QUIC when there is bad packet loss rate (50% of the packets are lost) for 4 consecutive crypto handshakes. For a session, during crypto handshake if there is a bad packet loss rate, then we mark that QUIC is recently broken for that host/port. We disable QUIC and close that connections if 4 consecutive handshakes have bad packet loss rate. QUIC was disabled for 0.002% of the time. We have been running the above experiment in M45 (in Canary, Dev and Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is faster by 4.4% (for data aggreagted for 28 days) when this experiment was enabled. R=rch@chromium.org Committed: https://crrev.com/147024676acbf52d08179457d2909314cf423a5c Cr-Commit-Position: refs/heads/master@{#347871}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix unit tests and merge with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/io_thread_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-03 19:46:31 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/1326763007/diff/1/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/1326763007/diff/1/net/http/http_network_session.cc#newcode107 net/http/http_network_session.cc:107: quic_packet_loss_threshold(0.5f), Do you need to change io_thread_unittests.cc to ...
5 years, 3 months ago (2015-09-08 17:53:41 UTC) #2
ramant (doing other things)
Thanks much Ryan. Fixed the io_thread_unittests. https://codereview.chromium.org/1326763007/diff/1/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/1326763007/diff/1/net/http/http_network_session.cc#newcode107 net/http/http_network_session.cc:107: quic_packet_loss_threshold(0.5f), On 2015/09/08 ...
5 years, 3 months ago (2015-09-08 19:46:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326763007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326763007/40001
5 years, 3 months ago (2015-09-08 21:34:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/66297)
5 years, 3 months ago (2015-09-08 23:00:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326763007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326763007/40001
5 years, 3 months ago (2015-09-09 03:03:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-09 09:07:34 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/147024676acbf52d08179457d2909314cf423a5c Cr-Commit-Position: refs/heads/master@{#347871}
5 years, 3 months ago (2015-09-09 09:08:43 UTC) #13
ramant (doing other things)
5 years, 2 months ago (2015-10-21 18:17:19 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1409143007/ by rtenneti@chromium.org.

The reason for reverting is: BUG=546089

We want to run bad packet loss as an experiment because on youtube, it had a
negative impact..

Powered by Google App Engine
This is Rietveld 408576698