Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1326763007: QUIC - Disable QUIC when there is bad packet loss rate (50% of the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests and merge with TOT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 2633f43bbff2306aaa3c0b736b3035668f460e7f..2d6a6c607fbe08a9ef70ffbe845c512a097b75bc 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -170,8 +170,8 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params.quic_disable_disk_cache);
EXPECT_FALSE(params.quic_prefer_aes);
EXPECT_FALSE(params.use_alternative_services);
- EXPECT_EQ(0, params.quic_max_number_of_lossy_connections);
- EXPECT_EQ(1.0f, params.quic_packet_loss_threshold);
+ EXPECT_EQ(4, params.quic_max_number_of_lossy_connections);
+ EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
}
@@ -384,11 +384,11 @@ TEST_F(IOThreadTest, QuicMaxNumberOfLossyConnectionsFieldTrialParams) {
TEST_F(IOThreadTest, QuicPacketLossThresholdFieldTrialParams) {
field_trial_group_ = "Enabled";
- field_trial_params_["packet_loss_threshold"] = "0.5";
+ field_trial_params_["packet_loss_threshold"] = "0.6";
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
+ EXPECT_EQ(0.6f, params.quic_packet_loss_threshold);
}
TEST_F(IOThreadTest, QuicReceiveBufferSize) {
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698