net/http/http_network_transaction.cc - Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_transaction.h ('K') | « net/http/http_network_transaction.h ('k') | net/http/http_network_transaction_unittest.cc » ('j') | net/http/http_stream_factory_impl_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index 8d02fedbe208d1d28e038c555bf62342c4a54d32..852dff9c72124d94665c32d3cba6231a46166dd3 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -524,6 +524,13 @@ void HttpNetworkTransaction::OnStreamReady(const SSLConfig& used_ssl_config,

OnIOComplete(OK);

}

+void HttpNetworkTransaction::OnBidirectionalStreamJobReady(

+ const SSLConfig& used_ssl_config,

+ const ProxyInfo& used_proxy_info,

+ BidirectionalStreamJob* stream) {

mef 2015/12/21 23:21:31 nit: I believe parameter name |stream| should matc

xunjieli 2015/12/22 02:58:48 Done.

+ NOTREACHED();

void HttpNetworkTransaction::OnWebSocketHandshakeStreamReady(

const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,