net/http/http_network_transaction.h - Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.h

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction.h

diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h

index f62b95123798f79cd7d73111db9da35271db3855..2045a48dcfcfb36a810f465e2466fce6b616de86 100644

--- a/net/http/http_network_transaction.h

+++ b/net/http/http_network_transaction.h

@@ -30,6 +30,7 @@

namespace net {

+class BidirectionalStreamJob;

class ClientSocketHandle;

class HttpAuthController;

class HttpNetworkSession;

@@ -90,6 +91,9 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction

void OnStreamReady(const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,

HttpStream* stream) override;

+ void OnBidirectionalStreamJobReady(const SSLConfig& used_ssl_config,

+ const ProxyInfo& used_proxy_info,

+ BidirectionalStreamJob* stream) override;

mef 2015/12/21 23:21:31 nit: I believe parameter name |stream| should matc

xunjieli 2015/12/22 02:58:49 Done.

void OnWebSocketHandshakeStreamReady(

const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,

« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_network_transaction.cc » ('j') | net/http/http_network_transaction.cc » ('J')