Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: net/http/http_network_transaction.cc

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_network_transaction.h" 5 #include "net/http/http_network_transaction.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 response_.was_npn_negotiated = stream_request_->was_npn_negotiated(); 517 response_.was_npn_negotiated = stream_request_->was_npn_negotiated();
518 response_.npn_negotiated_protocol = SSLClientSocket::NextProtoToString( 518 response_.npn_negotiated_protocol = SSLClientSocket::NextProtoToString(
519 stream_request_->protocol_negotiated()); 519 stream_request_->protocol_negotiated());
520 response_.was_fetched_via_spdy = stream_request_->using_spdy(); 520 response_.was_fetched_via_spdy = stream_request_->using_spdy();
521 response_.was_fetched_via_proxy = !proxy_info_.is_direct(); 521 response_.was_fetched_via_proxy = !proxy_info_.is_direct();
522 if (response_.was_fetched_via_proxy && !proxy_info_.is_empty()) 522 if (response_.was_fetched_via_proxy && !proxy_info_.is_empty())
523 response_.proxy_server = proxy_info_.proxy_server().host_port_pair(); 523 response_.proxy_server = proxy_info_.proxy_server().host_port_pair();
524 OnIOComplete(OK); 524 OnIOComplete(OK);
525 } 525 }
526 526
527 void HttpNetworkTransaction::OnBidirectionalStreamJobReady(
528 const SSLConfig& used_ssl_config,
529 const ProxyInfo& used_proxy_info,
530 BidirectionalStreamJob* stream) {
mef 2015/12/21 23:21:31 nit: I believe parameter name |stream| should matc
xunjieli 2015/12/22 02:58:48 Done.
531 NOTREACHED();
532 }
533
527 void HttpNetworkTransaction::OnWebSocketHandshakeStreamReady( 534 void HttpNetworkTransaction::OnWebSocketHandshakeStreamReady(
528 const SSLConfig& used_ssl_config, 535 const SSLConfig& used_ssl_config,
529 const ProxyInfo& used_proxy_info, 536 const ProxyInfo& used_proxy_info,
530 WebSocketHandshakeStreamBase* stream) { 537 WebSocketHandshakeStreamBase* stream) {
531 OnStreamReady(used_ssl_config, used_proxy_info, stream); 538 OnStreamReady(used_ssl_config, used_proxy_info, stream);
532 } 539 }
533 540
534 void HttpNetworkTransaction::OnStreamFailed(int result, 541 void HttpNetworkTransaction::OnStreamFailed(int result,
535 const SSLConfig& used_ssl_config, 542 const SSLConfig& used_ssl_config,
536 SSLFailureState ssl_failure_state) { 543 SSLFailureState ssl_failure_state) {
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 DCHECK(stream_request_); 1708 DCHECK(stream_request_);
1702 1709
1703 // Since the transaction can restart with auth credentials, it may create a 1710 // Since the transaction can restart with auth credentials, it may create a
1704 // stream more than once. Accumulate all of the connection attempts across 1711 // stream more than once. Accumulate all of the connection attempts across
1705 // those streams by appending them to the vector: 1712 // those streams by appending them to the vector:
1706 for (const auto& attempt : stream_request_->connection_attempts()) 1713 for (const auto& attempt : stream_request_->connection_attempts())
1707 connection_attempts_.push_back(attempt); 1714 connection_attempts_.push_back(attempt);
1708 } 1715 }
1709 1716
1710 } // namespace net 1717 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698