Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1325463002: Don't skip retries when force-running broken tests. (Closed)

Created:
5 years, 3 months ago by carlosk
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't skip retries when forcing running brokent tests. When using the test-launcher-force-run-broken-tests switch retries will not get skipped either. BUG=504347 Committed: https://crrev.com/bacb6f736ce237197cebfa0e77c99c4c403b42e9 Cr-Commit-Position: refs/heads/master@{#346127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_switches.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
carlosk
phajdan.jr@: PTAL. Others: FYI. To limit the number of not-recommended switches I just extending the ...
5 years, 3 months ago (2015-08-28 11:32:08 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 3 months ago (2015-08-28 11:36:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325463002/1
5 years, 3 months ago (2015-08-28 12:04:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 12:33:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 12:33:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bacb6f736ce237197cebfa0e77c99c4c403b42e9
Cr-Commit-Position: refs/heads/master@{#346127}

Powered by Google App Engine
This is Rietveld 408576698