Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: base/test/launcher/test_launcher.h

Issue 1325463002: Don't skip retries when force-running broken tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_ 5 #ifndef BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
6 #define BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_ 6 #define BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 // Number of tests either timing out or having an unknown result, 174 // Number of tests either timing out or having an unknown result,
175 // likely indicating a more systemic problem if widespread. 175 // likely indicating a more systemic problem if widespread.
176 size_t test_broken_count_; 176 size_t test_broken_count_;
177 177
178 // Number of retries in this iteration. 178 // Number of retries in this iteration.
179 size_t retry_count_; 179 size_t retry_count_;
180 180
181 // Maximum number of retries per iteration. 181 // Maximum number of retries per iteration.
182 size_t retry_limit_; 182 size_t retry_limit_;
183 183
184 // If true will not early exit even if too many tests are broken. 184 // If true will not early exit nor skip retries even if too many tests are
185 // broken.
185 bool force_run_broken_tests_; 186 bool force_run_broken_tests_;
186 187
187 // Tests to retry in this iteration. 188 // Tests to retry in this iteration.
188 std::set<std::string> tests_to_retry_; 189 std::set<std::string> tests_to_retry_;
189 190
190 // Result to be returned from Run. 191 // Result to be returned from Run.
191 bool run_result_; 192 bool run_result_;
192 193
193 TestResultsTracker results_tracker_; 194 TestResultsTracker results_tracker_;
194 195
195 // Watchdog timer to make sure we do not go without output for too long. 196 // Watchdog timer to make sure we do not go without output for too long.
196 DelayTimer<TestLauncher> watchdog_timer_; 197 DelayTimer<TestLauncher> watchdog_timer_;
197 198
198 // Number of jobs to run in parallel. 199 // Number of jobs to run in parallel.
199 size_t parallel_jobs_; 200 size_t parallel_jobs_;
200 201
201 // Worker pool used to launch processes in parallel. 202 // Worker pool used to launch processes in parallel.
202 scoped_ptr<SequencedWorkerPoolOwner> worker_pool_owner_; 203 scoped_ptr<SequencedWorkerPoolOwner> worker_pool_owner_;
203 204
204 DISALLOW_COPY_AND_ASSIGN(TestLauncher); 205 DISALLOW_COPY_AND_ASSIGN(TestLauncher);
205 }; 206 };
206 207
207 // Extract part from |full_output| that applies to |result|. 208 // Extract part from |full_output| that applies to |result|.
208 std::string GetTestOutputSnippet(const TestResult& result, 209 std::string GetTestOutputSnippet(const TestResult& result,
209 const std::string& full_output); 210 const std::string& full_output);
210 211
211 } // namespace base 212 } // namespace base
212 213
213 #endif // BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_ 214 #endif // BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
OLDNEW
« no previous file with comments | « no previous file | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698