Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: base/test/launcher/test_launcher.cc

Issue 1325463002: Don't skip retries when force-running broken tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/launcher/test_launcher.h ('k') | base/test/test_switches.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/launcher/test_launcher.h" 5 #include "base/test/launcher/test_launcher.h"
6 6
7 #if defined(OS_POSIX) 7 #if defined(OS_POSIX)
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #endif 9 #endif
10 10
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 } 637 }
638 638
639 if (test_finished_count_ != test_started_count_) 639 if (test_finished_count_ != test_started_count_)
640 return; 640 return;
641 641
642 if (tests_to_retry_.empty() || retry_count_ >= retry_limit_) { 642 if (tests_to_retry_.empty() || retry_count_ >= retry_limit_) {
643 OnTestIterationFinished(); 643 OnTestIterationFinished();
644 return; 644 return;
645 } 645 }
646 646
647 if (tests_to_retry_.size() >= broken_threshold) { 647 if (!force_run_broken_tests_ && tests_to_retry_.size() >= broken_threshold) {
648 fprintf(stdout, 648 fprintf(stdout,
649 "Too many failing tests (%" PRIuS "), skipping retries.\n", 649 "Too many failing tests (%" PRIuS "), skipping retries.\n",
650 tests_to_retry_.size()); 650 tests_to_retry_.size());
651 fflush(stdout); 651 fflush(stdout);
652 652
653 results_tracker_.AddGlobalTag("BROKEN_TEST_SKIPPED_RETRIES"); 653 results_tracker_.AddGlobalTag("BROKEN_TEST_SKIPPED_RETRIES");
654 results_tracker_.AddGlobalTag(kUnreliableResultsTag); 654 results_tracker_.AddGlobalTag(kUnreliableResultsTag);
655 655
656 OnTestIterationFinished(); 656 OnTestIterationFinished();
657 return; 657 return;
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 } 1083 }
1084 1084
1085 std::string snippet(full_output.substr(run_pos)); 1085 std::string snippet(full_output.substr(run_pos));
1086 if (end_pos != std::string::npos) 1086 if (end_pos != std::string::npos)
1087 snippet = full_output.substr(run_pos, end_pos - run_pos); 1087 snippet = full_output.substr(run_pos, end_pos - run_pos);
1088 1088
1089 return snippet; 1089 return snippet;
1090 } 1090 }
1091 1091
1092 } // namespace base 1092 } // namespace base
OLDNEW
« no previous file with comments | « base/test/launcher/test_launcher.h ('k') | base/test/test_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698