Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1324643005: bindings: Makes installV8FooTemplate thread-safe. (Closed)

Created:
5 years, 3 months ago by Yuki
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Makes installV8FooTemplate thread-safe. 'static const' initialization in functions is considered as thread-unsafe (data race). Removes 'static const' initialization, and uses simple 'const' initialization instead. Note: 'static' keyword in the top-level 'static const' initialization has no meaning. 'const' implies file-scope, so no need to explicitly write 'static' in that case. BUG=526963, 526959 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201870

Patch Set 1 #

Patch Set 2 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M Source/bindings/templates/constants.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/conversions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 10 chunks +23 lines, -23 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 10 chunks +17 lines, -17 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
5 years, 3 months ago (2015-09-07 09:17:21 UTC) #2
haraken
LGTM I don't think this affects performance given that DOM template installation happens only at ...
5 years, 3 months ago (2015-09-07 09:32:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324643005/20001
5 years, 3 months ago (2015-09-07 09:33:28 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 10:31:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201870

Powered by Google App Engine
This is Rietveld 408576698