Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: Source/bindings/templates/constants.cpp

Issue 1324643005: bindings: Makes installV8FooTemplate thread-safe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/conversions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/constants.cpp
diff --git a/Source/bindings/templates/constants.cpp b/Source/bindings/templates/constants.cpp
index d35639bb71caaf90faaf54f832f9d00ef3b22085..bac23ca38f6fa129543b54c134c7c6d3b8336fa0 100644
--- a/Source/bindings/templates/constants.cpp
+++ b/Source/bindings/templates/constants.cpp
@@ -27,7 +27,7 @@ static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v
{% macro install_constants() %}
{% if constant_configuration_constants %}
{# Normal constants #}
-static const V8DOMConfiguration::ConstantConfiguration {{v8_class}}Constants[] = {
+const V8DOMConfiguration::ConstantConfiguration {{v8_class}}Constants[] = {
{% for constant in constant_configuration_constants %}
{{constant_configuration(constant)}},
{% endfor %}
@@ -39,7 +39,7 @@ V8DOMConfiguration::installConstants(isolate, functionTemplate, prototypeTemplat
{% filter runtime_enabled(constant_tuple[0]) %}
{% for constant in constant_tuple[1] %}
{% set constant_name = constant.name.title().replace('_', '') %}
-static const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Configuration = {{constant_configuration(constant)}};
+const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Configuration = {{constant_configuration(constant)}};
V8DOMConfiguration::installConstant(isolate, functionTemplate, prototypeTemplate, constant{{constant_name}}Configuration);
{% endfor %}
{% endfilter %}
« no previous file with comments | « no previous file | Source/bindings/templates/conversions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698