Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 1324643005: bindings: Makes installV8FooTemplate thread-safe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index 88586c46b259e03fe44db2508c4b32099d02663a..e79f42b278d7ba9a23382c7772e4ec26ed5c52b3 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -225,7 +225,7 @@ bool namedSecurityCheck(v8::Local<v8::Object> host, v8::Local<v8::Value> key, v8
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wglobal-constructors"
#endif
-static const V8DOMConfiguration::AttributeConfiguration {{v8_class}}Attributes[] = {
+const V8DOMConfiguration::AttributeConfiguration {{v8_class}}Attributes[] = {
{% for attribute in attributes
if not (attribute.exposed_test or
attribute.runtime_enabled_function) and
@@ -246,7 +246,7 @@ static const V8DOMConfiguration::AttributeConfiguration {{v8_class}}Attributes[]
{% block install_accessors %}
{% from 'attributes.cpp' import attribute_configuration with context %}
{% if has_accessor_configuration %}
-static const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] = {
+const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] = {
{% for attribute in attributes
if not (attribute.exposed_test or
attribute.runtime_enabled_function) and
@@ -264,7 +264,7 @@ static const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] =
{% block install_methods %}
{% from 'methods.cpp' import method_configuration with context %}
{% if method_configuration_methods %}
-static const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
+const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
{% for method in method_configuration_methods %}
{% filter conditional(method.conditional_string) %}
{{method_configuration(method)}},
@@ -352,11 +352,11 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function
{% filter conditional(attribute.conditional_string) %}
if ({{attribute.runtime_enabled_function}}()) {
{% if attribute.is_data_type_property %}
- static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration = \
+ const V8DOMConfiguration::AttributeConfiguration attributeConfiguration = \
{{attribute_configuration(attribute)}};
V8DOMConfiguration::installAttribute(isolate, instanceTemplate, prototypeTemplate, attributeConfiguration);
{% else %}
- static const V8DOMConfiguration::AccessorConfiguration accessorConfiguration = \
+ const V8DOMConfiguration::AccessorConfiguration accessorConfiguration = \
{{attribute_configuration(attribute)}};
V8DOMConfiguration::installAccessor(isolate, instanceTemplate, prototypeTemplate, functionTemplate, defaultSignature, accessorConfiguration);
{% endif %}
@@ -427,7 +427,7 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function
{% if iterator_method %}
{% filter exposed(iterator_method.exposed_test) %}
{% filter runtime_enabled(iterator_method.runtime_enabled_function) %}
- static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{cpp_class_or_partial}}V8Internal::iteratorMethodCallback, 0, V8DOMConfiguration::ExposedToAllScripts };
+ const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{cpp_class_or_partial}}V8Internal::iteratorMethodCallback, 0, V8DOMConfiguration::ExposedToAllScripts };
V8DOMConfiguration::installMethod(isolate, prototypeTemplate, defaultSignature, v8::DontDelete, symbolKeyedIteratorConfiguration);
{% endfilter %}{# runtime_enabled() #}
{% endfilter %}{# exposed() #}
« no previous file with comments | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698