Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1323443002: Add a class comment to LayoutText (Closed)

Created:
5 years, 3 months ago by Julien - ping for review
Modified:
5 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add a class comment to LayoutText The class was sorely missing some documentation about the design decisions and its purpose. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201360

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch with more documentation. #

Total comments: 4

Patch Set 3 : Updated after Emil's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M Source/core/layout/LayoutText.h View 1 2 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Julien - ping for review
5 years, 3 months ago (2015-08-27 22:16:07 UTC) #2
eae
https://codereview.chromium.org/1323443002/diff/1/Source/core/layout/LayoutText.h File Source/core/layout/LayoutText.h (right): https://codereview.chromium.org/1323443002/diff/1/Source/core/layout/LayoutText.h#newcode51 Source/core/layout/LayoutText.h:51: // See e.g. LayoutBlockFlow::layoutInlineChildren. It is probably worth pointing ...
5 years, 3 months ago (2015-08-27 22:22:25 UTC) #3
eae
Awesome, LGTM with nits. Please commit directly once addressed, no need for another round of ...
5 years, 3 months ago (2015-08-28 00:32:33 UTC) #4
Julien - ping for review
Updated thanks for the review! https://codereview.chromium.org/1323443002/diff/20001/Source/core/layout/LayoutText.h File Source/core/layout/LayoutText.h (right): https://codereview.chromium.org/1323443002/diff/20001/Source/core/layout/LayoutText.h#newcode50 Source/core/layout/LayoutText.h:50: // Bidirectional Algorithm algorithm ...
5 years, 3 months ago (2015-08-28 02:18:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323443002/40001
5 years, 3 months ago (2015-08-28 02:18:49 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 03:03:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201360

Powered by Google App Engine
This is Rietveld 408576698