Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323233004: Adds better security checking to OnCreatedFrame() (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds better security checking to OnCreatedFrame() Not quite perfect, but better. BUG=479172, 490221 TEST=none R=ben@chromium.org Committed: https://crrev.com/dbdd6f28df94a1a7e2475f47ba7c40d9886ea68e Cr-Commit-Position: refs/heads/master@{#348011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -46 lines) Patch
M components/html_viewer/html_frame_apptest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/web_view/frame.h View 6 chunks +11 lines, -3 lines 0 comments Download
M components/web_view/frame.cc View 9 chunks +37 lines, -20 lines 0 comments Download
M components/web_view/frame_apptest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/web_view/frame_tree.h View 3 chunks +6 lines, -4 lines 0 comments Download
M components/web_view/frame_tree.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M components/web_view/web_view_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/application/public/cpp/lib/application_test_main.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
5 years, 3 months ago (2015-09-09 17:34:55 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 3 months ago (2015-09-09 21:26:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323233004/1
5 years, 3 months ago (2015-09-09 21:28:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 21:34:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dbdd6f28df94a1a7e2475f47ba7c40d9886ea68e Cr-Commit-Position: refs/heads/master@{#348011}
5 years, 3 months ago (2015-09-09 21:35:32 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:03:41 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dbdd6f28df94a1a7e2475f47ba7c40d9886ea68e
Cr-Commit-Position: refs/heads/master@{#348011}

Powered by Google App Engine
This is Rietveld 408576698