Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/web_view/frame_apptest.cc

Issue 1323233004: Adds better security checking to OnCreatedFrame() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/frame.cc ('k') | components/web_view/frame_tree.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/frame_apptest.cc
diff --git a/components/web_view/frame_apptest.cc b/components/web_view/frame_apptest.cc
index 8fb2357317fc4e1a22f982adc603a4ed7dbd5b4a..c952d84698090af14f319e5e1e602293a426ab14 100644
--- a/components/web_view/frame_apptest.cc
+++ b/components/web_view/frame_apptest.cc
@@ -175,8 +175,8 @@ class TestFrameTreeClient : public FrameTreeClient {
TEST_F(FrameTest, RootGetsConnect) {
TestFrameTreeDelegate tree_delegate;
TestFrameTreeClient root_client;
- FrameTree tree(0u, window_manager()->GetRoot(), &tree_delegate, &root_client,
- nullptr, Frame::ClientPropertyMap());
+ FrameTree tree(0u, window_manager()->GetRoot(), nullptr, &tree_delegate,
+ &root_client, nullptr, Frame::ClientPropertyMap());
ASSERT_EQ(1, root_client.connect_count());
mojo::Array<FrameDataPtr> frames = root_client.connect_frames();
ASSERT_EQ(1u, frames.size());
@@ -188,8 +188,8 @@ TEST_F(FrameTest, RootGetsConnect) {
TEST_F(FrameTest, SingleChild) {
TestFrameTreeDelegate tree_delegate;
TestFrameTreeClient root_client;
- FrameTree tree(0u, window_manager()->GetRoot(), &tree_delegate, &root_client,
- nullptr, Frame::ClientPropertyMap());
+ FrameTree tree(0u, window_manager()->GetRoot(), nullptr, &tree_delegate,
+ &root_client, nullptr, Frame::ClientPropertyMap());
View* child = window_manager()->CreateView();
EXPECT_EQ(nullptr, Frame::FindFirstFrameAncestor(child));
« no previous file with comments | « components/web_view/frame.cc ('k') | components/web_view/frame_tree.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698