components/web_view/web_view_impl.cc - Issue 1323233004: Adds better security checking to OnCreatedFrame()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/web_view_impl.cc

Issue 1323233004: Adds better security checking to OnCreatedFrame() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_view/web_view_impl.cc

diff --git a/components/web_view/web_view_impl.cc b/components/web_view/web_view_impl.cc

index e73058937ec679c22701d31446d6c1c148c9083c..9d04651edc6d0395fb20e659b340f071883c113c 100644

--- a/components/web_view/web_view_impl.cc

+++ b/components/web_view/web_view_impl.cc

@@ -69,10 +69,9 @@ void WebViewImpl::OnLoad() {

FrameTreeClient* frame_tree_client = frame_connection->frame_tree_client();

const uint32_t content_handler_id = frame_connection->GetContentHandlerID();

- frame_tree_.reset(new FrameTree(content_handler_id, content_, this,

- frame_tree_client, frame_connection.Pass(),

- client_properties));

- content_->Embed(view_tree_client.Pass());

+ frame_tree_.reset(new FrameTree(

+ content_handler_id, content_, view_tree_client.Pass(), this,

+ frame_tree_client, frame_connection.Pass(), client_properties));

}

////////////////////////////////////////////////////////////////////////////////

« no previous file with comments | « components/web_view/frame_tree.cc ('k') | mojo/application/public/cpp/BUILD.gn » ('j') | no next file with comments »