Define "opaque" FormData objects.

Define "opaque" FormData objects.

As defined at [1], opaque FormData objects block JavaScript access to
'get()', 'getAll()', 'has()', and iteration. The data is available
internally for consumption in Fetch, but can't be directly accessed by
JavaScript in a page's context.

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#opaque-formdata

BUG=526995
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201559

[Mike West, 2015-09-01 09:41:43]

mkwst@chromium.org changed reviewers:
+ philipj@opera.com

[Mike West, 2015-09-01 09:41:44]

Mind taking a look at this, Philip?

-mike

[philipj_slow, 2015-09-01 11:53:12]

Should there be some caller to makeOpaque() somewhere, and is this observable to
scripts so that it's possible to write a test with testharness.js?

As for the spec, shouldn't this be part of
https://xhr.spec.whatwg.org/#interface-formdata instead? Only one spec can
monkey patch a given method until it becomes undefined what the order of
operations should be...

[Mike West, 2015-09-01 12:05:54]

On 2015/09/01 at 11:53:12, philipj wrote:
> Should there be some caller to makeOpaque() somewhere, and is this observable
to scripts so that it's possible to write a test with testharness.js?

I guess I wouldn't mind exposing the opaque setter to the web. *shrug*

> As for the spec, shouldn't this be part of
https://xhr.spec.whatwg.org/#interface-formdata instead? Only one spec can
monkey patch a given method until it becomes undefined what the order of
operations should be...

Anne asked me to dump all this into CREDENTIAL until it's clear what we're
actually doing. Then I'll certainly send him PRs to move my monkeypatches into
XHR proper.

[philipj_slow, 2015-09-01 12:36:32]

LGTM, I don't know if the web-exposed makeOpaque() is actually useful, but maybe
for feature detection of opaque FormData objects?

[Mike West, 2015-09-01 13:06:44]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-09-01 13:06:44]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1323043002/#ps60001
(title: "Dropping makeOpaque again.")

[commit-bot: I haz the power, 2015-09-01 13:06:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323043002/60001

[Mike West, 2015-09-01 13:06:59]

On 2015/09/01 at 12:36:32, philipj wrote:
> LGTM, I don't know if the web-exposed makeOpaque() is actually useful, but
maybe for feature detection of opaque FormData objects?

Dropped it again after talking with Anne.

[commit-bot: I haz the power, 2015-09-01 16:06:00]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201559