CREDENTIAL: Add 'PasswordCredential::toFormData()'

CREDENTIAL: Add 'PasswordCredential::toFormData()'

The API has evolved a bit, dropping the 'password' and 'formData'
accessors in favor of a 'toFormData(FormDataOptions)' method which
is intended to be used in conjunction with 'fetch()' to submit
credentials to a server-side endpoint.

Defined at [1] and [2].

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential
[2]: https://w3c.github.io/webappsec/specs/credentialmanagement/#generate-formdata

BUG=526995
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201631

[Mike West, 2015-09-01 10:48:09]

mkwst@chromium.org changed reviewers:
+ philipj@opera.com

[Mike West, 2015-09-01 10:48:20]

Mind taking a look at this too, Philip?

-mike

[philipj_slow, 2015-09-01 12:37:30]

LGTM even though I'm pretty clueless about the high-level picture here :)

https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
File Source/modules/credentialmanager/PasswordCredential.cpp (right):

https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
Source/modules/credentialmanager/PasswordCredential.cpp:51:
fd->append(options.idName(), id());
I see that one can vary the key with the FormDataOptions dictionary, but what is
this used for?

[Mike West, 2015-09-01 12:48:00]

On 2015/09/01 at 12:37:30, philipj wrote:
> LGTM even though I'm pretty clueless about the high-level picture here :)

Clueless reviews are the best!
 
>
https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
> File Source/modules/credentialmanager/PasswordCredential.cpp (right):
> 
>
https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
> Source/modules/credentialmanager/PasswordCredential.cpp:51:
fd->append(options.idName(), id());
> I see that one can vary the key with the FormDataOptions dictionary, but what
is this used for?

The idea is that one page might call the credential's ID "username", while
another might call it "u", and still another "benutzername". Ideally, folks will
be able to layer this API on top of an existing login system without changing
backend code, so we need to be a bit flexible with regard to the naming.

[philipj_slow, 2015-09-01 13:03:59]

On 2015/09/01 12:48:00, Mike West (OOO until 31st) wrote:
> On 2015/09/01 at 12:37:30, philipj wrote:
> > LGTM even though I'm pretty clueless about the high-level picture here :)
> 
> Clueless reviews are the best!
>  
> >
>
https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
> > File Source/modules/credentialmanager/PasswordCredential.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1317043003/diff/40001/Source/modules/credenti...
> > Source/modules/credentialmanager/PasswordCredential.cpp:51:
> fd->append(options.idName(), id());
> > I see that one can vary the key with the FormDataOptions dictionary, but
what
> is this used for?
> 
> The idea is that one page might call the credential's ID "username", while
> another might call it "u", and still another "benutzername". Ideally, folks
will
> be able to layer this API on top of an existing login system without changing
> backend code, so we need to be a bit flexible with regard to the naming.

Got it!

[Mike West, 2015-09-01 13:12:17]

On 2015/09/01 at 13:03:59, philipj wrote:
> > The idea is that one page might call the credential's ID "username", while
> > another might call it "u", and still another "benutzername". Ideally, folks
will
> > be able to layer this API on top of an existing login system without
changing
> > backend code, so we need to be a bit flexible with regard to the naming.
> 
> Got it!

Moved the opaque FormData tests from the previous CL to this one. Thanks for
working through it with me!

[philipj_slow, 2015-09-01 13:23:24]

Tweaked tests LGTM

[Mike West, 2015-09-01 16:06:58]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-09-01 16:07:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317043003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317043003/60001

[commit-bot: I haz the power, 2015-09-01 17:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 17:26:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2015-09-02 07:04:36]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-09-02 07:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1317043003/#ps80001
(title: "webexposed")

[commit-bot: I haz the power, 2015-09-02 07:04:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317043003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317043003/80001

[commit-bot: I haz the power, 2015-09-02 08:29:22]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201631