Revert of Allow direct and indirect navigation values to be varied via field trial.

Revert of Allow direct and indirect navigation values to be varied via field trial. (patchset #3 id:60001 of https://codereview.chromium.org/1309803005/ )

Reason for revert:
Looks like this broke org.chromium.chrome.browser.banners.AppBannerManagerTest : http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29822
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/21895

Original issue's description:
> Allow direct and indirect navigation values to be varied via field trial.
>
> This CL allows the engagement scores assigned to direct and indirect
> navigations to be varied via a field trial. It also makes method names
> related to the setting of values in AppBannerSettingsHelper more
> consistent.
>
> BUG=487519
>
> Committed: https://crrev.com/633bbe04d2525d7272a78d78f8e3fdd0abe4d5a2
> Cr-Commit-Position: refs/heads/master@{#345729}

TBR=benwells@chromium.org,dfalcantara@chromium.org,dominickn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487519
Committed: https://crrev.com/22586e128b6861c2674025a836998e9ef59db51c
Cr-Commit-Position: refs/heads/master@{#345793}

[Nico, 2015-08-27 04:23:36]

Created Revert of Allow direct and indirect navigation values to be varied via
field trial.

[commit-bot: I haz the power, 2015-08-27 04:23:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322503002/1

[commit-bot: I haz the power, 2015-08-27 04:24:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-27 04:25:07]

Patchset 1 (id:??) landed as
https://crrev.com/22586e128b6861c2674025a836998e9ef59db51c
Cr-Commit-Position: refs/heads/master@{#345793}

[Nico, 2015-08-27 06:16:02]

This surprisingly (to me) didn't help:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
has the revert, yet the test is still red there.

Do you know why this test might've turned red when the initial CL landed?

[dominickn, 2015-08-27 06:26:44]

On 2015/08/27 06:16:02, Nico wrote:
> This surprisingly (to me) didn't help:
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
> has the revert, yet the test is still red there.
> 
> Do you know why this test might've turned red when the initial CL landed?

Yes. It was actually caused by https://codereview.chromium.org/1312343003/. I
landed both of these in close succession. While this one touches the test file,
it's actually the other one that introduces the failure.

Can you please reland this, revert the other one, and I'll amend the offending
CL appropriately?

[Nico, 2015-08-27 06:27:29]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1314273004/ by thakis@chromium.org.

The reason for reverting is: The revert didn't help..

[Nico, 2015-08-27 06:28:23]

Will do, thanks!

On Wed, Aug 26, 2015 at 9:23 PM, <thakis@chromium.org> wrote:

> Reviewers: benwells, dfalcantara, dominickn,
>
> Message:
> Created Revert of Allow direct and indirect navigation values to be varied
> via
> field trial.
>
> Description:
> Revert of Allow direct and indirect navigation values to be varied via
> field
> trial. (patchset #3 id:60001 of
> https://codereview.chromium.org/1309803005/ )
>
> Reason for revert:
> Looks like this broke
> org.chromium.chrome.browser.banners.AppBannerManagerTest :
>
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
>
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/21895
>
> Original issue's description:
>
>> Allow direct and indirect navigation values to be varied via field trial.
>>
>
> This CL allows the engagement scores assigned to direct and indirect
>> navigations to be varied via a field trial. It also makes method names
>> related to the setting of values in AppBannerSettingsHelper more
>> consistent.
>>
>
> BUG=487519
>>
>
> Committed: https://crrev.com/633bbe04d2525d7272a78d78f8e3fdd0abe4d5a2
>> Cr-Commit-Position: refs/heads/master@{#345729}
>>
>
> TBR=benwells@chromium.org,dfalcantara@chromium.org,dominickn@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487519
>
> Please review this at https://codereview.chromium.org/1322503002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+30, -68 lines):
>   M
>
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
>   M
>
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
>   M chrome/browser/android/banners/app_banner_manager_android.cc
>   M chrome/browser/banners/app_banner_manager.h
>   M chrome/browser/banners/app_banner_manager.cc
>   M chrome/browser/banners/app_banner_settings_helper.h
>   M chrome/browser/banners/app_banner_settings_helper.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.