Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4244)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1322503002: Revert of Allow direct and indirect navigation values to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 31e4aa42a3b16a93691970bc68f3e33f52e24399..b6fa211a2a05022efd039efa26b381a6f5aef463 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -157,8 +157,9 @@
/** Sets the weights of direct and indirect page navigations for testing. */
@VisibleForTesting
- static void setEngagementWeights(double directEngagement, double indirectEngagement) {
- nativeSetEngagementWeights(directEngagement, indirectEngagement);
+ static void forceEngagementWeightsForTesting(double directEngagement,
+ double indirectEngagement) {
+ nativeForceEngagementWeightsForTesting(directEngagement, indirectEngagement);
}
/** Returns whether a AppBannerDataFetcher is actively retrieving data. */
@@ -178,7 +179,7 @@
// Testing methods.
private static native void nativeSetTimeDeltaForTesting(int days);
private static native void nativeDisableSecureSchemeCheckForTesting();
- private static native void nativeSetEngagementWeights(double directEngagement,
- double indirectEngagement);
+ private static native void nativeForceEngagementWeightsForTesting(
+ double directEngagement, double indirectEngagement);
private native boolean nativeIsFetcherActive(long nativeAppBannerManagerAndroid);
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698