Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2300)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1322503002: Revert of Allow direct and indirect navigation values to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/browser/banners/app_banner_settings_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 0f5efab72a203974b3e215b03b76f616d524cee4..777ef1ae514c4a6ed9f549fe54c85f76a423160d 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -31,7 +31,7 @@
: ideal_icon_size_(icon_size),
data_fetcher_(nullptr),
weak_factory_(this) {
- AppBannerSettingsHelper::UpdateFromFieldTrial();
+ AppBannerSettingsHelper::UpdateMinutesBetweenVisits();
}
AppBannerManager::AppBannerManager(content::WebContents* web_contents,
@@ -40,7 +40,7 @@
ideal_icon_size_(icon_size),
data_fetcher_(nullptr),
weak_factory_(this) {
- AppBannerSettingsHelper::UpdateFromFieldTrial();
+ AppBannerSettingsHelper::UpdateMinutesBetweenVisits();
}
AppBannerManager::~AppBannerManager() {
@@ -106,8 +106,9 @@
gDisableSecureCheckForTesting = true;
}
-void AppBannerManager::SetEngagementWeights(double direct_engagement,
- double indirect_engagement) {
+void AppBannerManager::ForceEngagementWeightsForTesting(
+ double direct_engagement,
+ double indirect_engagement) {
AppBannerSettingsHelper::SetEngagementWeights(direct_engagement,
indirect_engagement);
}
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/browser/banners/app_banner_settings_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698