[#6]Pass gfx structs by const ref (gfx::Vector2d)

Pass gfx structs by const ref (gfx::Vector2d)
Avoid unneccessary copy of structures gfx::Vector2d
by passing them by const ref rather than value.

Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.


Pass gfx structs by const ref (gfx::Vector2d)

BUG=159273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248941

[r.kasibhatla, 2014-01-24 05:32:15]

Correct the 2 issues.

https://codereview.chromium.org/132163009/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (right):

https://codereview.chromium.org/132163009/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:27: bool partial_update) {
The alignment is wrong. Correct it.

https://codereview.chromium.org/132163009/diff/1/cc/trees/layer_tree_host_cli...
File cc/trees/layer_tree_host_client.h (right):

https://codereview.chromium.org/132163009/diff/1/cc/trees/layer_tree_host_cli...
cc/trees/layer_tree_host_client.h:29: float page_scale) = 0;
Missed the override in this file -mojo/examples/compositor_app/compositor_host.h

[Berwal, 2014-01-24 07:40:41]

On 2014/01/24 05:32:15, r.kasibhatla wrote:
> Correct the 2 issues.
> 
>
https://codereview.chromium.org/132163009/diff/1/cc/resources/bitmap_content_...
> File cc/resources/bitmap_content_layer_updater.cc (right):
> 
>
https://codereview.chromium.org/132163009/diff/1/cc/resources/bitmap_content_...
> cc/resources/bitmap_content_layer_updater.cc:27: bool partial_update) {
> The alignment is wrong. Correct it.
> 
>
https://codereview.chromium.org/132163009/diff/1/cc/trees/layer_tree_host_cli...
> File cc/trees/layer_tree_host_client.h (right):
> 
>
https://codereview.chromium.org/132163009/diff/1/cc/trees/layer_tree_host_cli...
> cc/trees/layer_tree_host_client.h:29: float page_scale) = 0;
> Missed the override in this file
-mojo/examples/compositor_app/compositor_host.h

Done.

[Berwal, 2014-01-24 13:36:49]

PTAL.......

[jdduke (slow), 2014-01-24 16:42:40]

On 2014/01/24 13:36:49, ajay.berwal wrote:
> PTAL.......

content/renderer/input lgtm

[Berwal, 2014-01-27 13:33:07]

@danakj PTAL at cc/
@Aoron Boodman PTAL at mojo/

[danakj, 2014-01-27 19:34:38]

LGTM

[commit-bot: I haz the power, 2014-01-28 18:18:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/270001

[danakj, 2014-01-28 18:19:32]

+piman for content/
+jamesr mojo/

[jamesr, 2014-01-28 18:22:38]

lgtm

[commit-bot: I haz the power, 2014-01-28 18:58:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-29 05:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/270001

[commit-bot: I haz the power, 2014-01-29 06:02:00]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Berwal, 2014-01-30 05:36:46]

@piman PTAL

[Berwal, 2014-01-31 12:11:50]

@avi PTAL content/

[Avi (use Gerrit), 2014-01-31 15:34:49]

Content lgtm

[Berwal, 2014-01-31 16:05:28]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-01-31 16:05:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/270001

[commit-bot: I haz the power, 2014-01-31 16:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-01-31 16:06:00]

Failed to apply patch for cc/layers/layer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/layers/layer.cc
  Hunk #1 succeeded at 679 with fuzz 2 (offset 2 lines).
  Hunk #2 succeeded at 693 (offset 8 lines).
  Hunk #3 FAILED at 700.
  1 out of 3 hunks FAILED -- saving rejects to file cc/layers/layer.cc.rej

Patch:       cc/layers/layer.cc
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index
f5850067c415af5bc11f9495d2933533904a32e7..3ca01a741a3ba01ecc728334a3f8c6b0aebadcd0
100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -677,7 +677,7 @@ void Layer::RemoveClipChild(Layer* child) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffset(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (scroll_offset_ == scroll_offset)
     return;
@@ -685,7 +685,7 @@ void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffsetFromImplSide(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   // This function only gets called during a BeginMainFrame, so there
   // is no need to call SetNeedsUpdate here.
@@ -700,7 +700,7 @@ void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d
scroll_offset) {
   // "this" may have been destroyed during the process.
 }
 
-void Layer::SetMaxScrollOffset(gfx::Vector2d max_scroll_offset) {
+void Layer::SetMaxScrollOffset(const gfx::Vector2d& max_scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (max_scroll_offset_ == max_scroll_offset)
     return;

[commit-bot: I haz the power, 2014-01-31 16:06:04]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 16:06:06]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-01-31 16:11:15]

The CQ bit was unchecked by ajay.berwal@samsung.com

[Berwal, 2014-01-31 16:11:16]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-01-31 16:11:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/270001

[commit-bot: I haz the power, 2014-01-31 16:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-01-31 16:11:48]

Failed to apply patch for cc/layers/layer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/layers/layer.cc
  Hunk #1 succeeded at 679 with fuzz 2 (offset 2 lines).
  Hunk #2 succeeded at 693 (offset 8 lines).
  Hunk #3 FAILED at 700.
  1 out of 3 hunks FAILED -- saving rejects to file cc/layers/layer.cc.rej

Patch:       cc/layers/layer.cc
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index
f5850067c415af5bc11f9495d2933533904a32e7..3ca01a741a3ba01ecc728334a3f8c6b0aebadcd0
100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -677,7 +677,7 @@ void Layer::RemoveClipChild(Layer* child) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffset(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (scroll_offset_ == scroll_offset)
     return;
@@ -685,7 +685,7 @@ void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffsetFromImplSide(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   // This function only gets called during a BeginMainFrame, so there
   // is no need to call SetNeedsUpdate here.
@@ -700,7 +700,7 @@ void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d
scroll_offset) {
   // "this" may have been destroyed during the process.
 }
 
-void Layer::SetMaxScrollOffset(gfx::Vector2d max_scroll_offset) {
+void Layer::SetMaxScrollOffset(const gfx::Vector2d& max_scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (max_scroll_offset_ == max_scroll_offset)
     return;

[commit-bot: I haz the power, 2014-01-31 16:11:54]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 16:11:56]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-01-31 22:28:42]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-01-31 22:29:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/270001

[commit-bot: I haz the power, 2014-01-31 22:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-01-31 22:29:35]

Failed to apply patch for cc/layers/layer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/layers/layer.cc
  Hunk #1 succeeded at 679 with fuzz 2 (offset 2 lines).
  Hunk #2 succeeded at 693 (offset 8 lines).
  Hunk #3 FAILED at 700.
  1 out of 3 hunks FAILED -- saving rejects to file cc/layers/layer.cc.rej

Patch:       cc/layers/layer.cc
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index
f5850067c415af5bc11f9495d2933533904a32e7..3ca01a741a3ba01ecc728334a3f8c6b0aebadcd0
100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -677,7 +677,7 @@ void Layer::RemoveClipChild(Layer* child) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffset(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (scroll_offset_ == scroll_offset)
     return;
@@ -685,7 +685,7 @@ void Layer::SetScrollOffset(gfx::Vector2d scroll_offset) {
   SetNeedsCommit();
 }
 
-void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d scroll_offset) {
+void Layer::SetScrollOffsetFromImplSide(const gfx::Vector2d& scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   // This function only gets called during a BeginMainFrame, so there
   // is no need to call SetNeedsUpdate here.
@@ -700,7 +700,7 @@ void Layer::SetScrollOffsetFromImplSide(gfx::Vector2d
scroll_offset) {
   // "this" may have been destroyed during the process.
 }
 
-void Layer::SetMaxScrollOffset(gfx::Vector2d max_scroll_offset) {
+void Layer::SetMaxScrollOffset(const gfx::Vector2d& max_scroll_offset) {
   DCHECK(IsPropertyChangeAllowed());
   if (max_scroll_offset_ == max_scroll_offset)
     return;

[commit-bot: I haz the power, 2014-01-31 22:29:38]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 22:29:42]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-02 18:59:04]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-02 18:59:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/390002

[commit-bot: I haz the power, 2014-02-02 19:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-02 19:17:53]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-02-02 19:17:54]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 19:17:55]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-02 20:09:22]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-02 20:09:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/730001

[commit-bot: I haz the power, 2014-02-02 20:27:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-02 20:27:16]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-02-02 20:27:24]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 20:27:25]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-03 09:26:58]

The CQ bit was unchecked by ajay.berwal@samsung.com

[Berwal, 2014-02-03 09:27:00]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-03 09:27:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/940001

[commit-bot: I haz the power, 2014-02-03 09:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-03 09:43:29]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-02-03 09:43:35]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 09:43:37]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-04 13:37:14]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-04 13:37:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/1160001

[commit-bot: I haz the power, 2014-02-04 13:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 13:38:22]

Failed to apply patch for cc/scheduler/texture_uploader.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: cc/scheduler/texture_uploader.cc
  |diff --git a/cc/scheduler/texture_uploader.cc
b/cc/scheduler/texture_uploader.cc
  |index
b15fe41fa55569c00e3ac3132608927df8ac6347..73bd2e7c80ede18063436756fb2604d8df88a46c
100644
  |--- a/cc/scheduler/texture_uploader.cc
  |+++ b/cc/scheduler/texture_uploader.cc
  --------------------------
  No file to patch.  Skipping patch.
  3 out of 3 hunks ignored

Patch:       cc/scheduler/texture_uploader.cc
Index: cc/scheduler/texture_uploader.cc
diff --git a/cc/scheduler/texture_uploader.cc b/cc/scheduler/texture_uploader.cc
index
b15fe41fa55569c00e3ac3132608927df8ac6347..73bd2e7c80ede18063436756fb2604d8df88a46c
100644
--- a/cc/scheduler/texture_uploader.cc
+++ b/cc/scheduler/texture_uploader.cc
@@ -131,7 +131,7 @@ void TextureUploader::EndQuery() {
 void TextureUploader::Upload(const uint8* image,
                              const gfx::Rect& image_rect,
                              const gfx::Rect& source_rect,
-                             gfx::Vector2d dest_offset,
+                             const gfx::Vector2d& dest_offset,
                              ResourceFormat format,
                              const gfx::Size& size) {
   CHECK(image_rect.Contains(source_rect));
@@ -175,7 +175,7 @@ void TextureUploader::ReleaseCachedQueries() {
 void TextureUploader::UploadWithTexSubImage(const uint8* image,
                                             const gfx::Rect& image_rect,
                                             const gfx::Rect& source_rect,
-                                            gfx::Vector2d dest_offset,
+                                            const gfx::Vector2d& dest_offset,
                                             ResourceFormat format) {
   TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage");
 
@@ -229,7 +229,7 @@ void TextureUploader::UploadWithTexSubImage(const uint8*
image,
 void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
                                                const gfx::Rect& image_rect,
                                                const gfx::Rect& source_rect,
-                                               gfx::Vector2d dest_offset,
+                                               const gfx::Vector2d&
dest_offset,
                                                ResourceFormat format) {
   TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage");

[skia-commit-bot, 2014-02-04 13:38:32]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-04 15:56:51]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-04 15:58:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/1240001

[commit-bot: I haz the power, 2014-02-04 16:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 16:40:01]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[skia-commit-bot, 2014-02-04 16:40:02]

CQ bit was unchecked on CL. Ignoring.

[Berwal, 2014-02-05 07:46:35]

The CQ bit was checked by ajay.berwal@samsung.com

[Berwal, 2014-02-05 07:46:35]

The CQ bit was unchecked by ajay.berwal@samsung.com

[Berwal, 2014-02-05 07:48:18]

The CQ bit was unchecked by ajay.berwal@samsung.com

[Berwal, 2014-02-05 07:48:49]

The CQ bit was checked by ajay.berwal@samsung.com

[commit-bot: I haz the power, 2014-02-05 07:51:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/132163009/1240001

[commit-bot: I haz the power, 2014-02-05 09:18:49]

Change committed as 248941