Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1307393004: Reland of Don't bother running realpath in DeviceUtils._GetChangedAndStaleFiles() (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't bother running realpath in DeviceUtils._GetChangedAndStaleFiles() (patchset #2 id:40001 of https://codereview.chromium.org/1306883004/ ) Reason for revert: - Now has realpath behaviour removed from md5sum. - Now md5sum.py detects when it should re-push an out-of-date binary. BUG=520082 Committed: https://crrev.com/a25d597f08a3b6ccd4020f9400e092842b563744 Cr-Commit-Position: refs/heads/master@{#346396}

Patch Set 1 #

Patch Set 2 : with md5sum.cc changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M build/android/pylib/device/device_utils.py View 1 3 chunks +7 lines, -16 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 1 2 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
agrieve
Created Reland of Don't bother running realpath in DeviceUtils._GetChangedAndStaleFiles()
5 years, 3 months ago (2015-08-27 03:25:12 UTC) #1
agrieve
On 2015/08/27 03:25:12, agrieve wrote: > Created Reland of Don't bother running realpath in > ...
5 years, 3 months ago (2015-08-27 13:47:33 UTC) #2
jbudorick
lgtm
5 years, 3 months ago (2015-08-28 18:38:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307393004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307393004/40001
5 years, 3 months ago (2015-08-31 15:22:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-08-31 16:28:03 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 16:28:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a25d597f08a3b6ccd4020f9400e092842b563744
Cr-Commit-Position: refs/heads/master@{#346396}

Powered by Google App Engine
This is Rietveld 408576698