Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: net/base/ssl_client_socket_unittest.cc

Issue 132081: Comments added to SSL unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ssl_client_socket_unittest.cc
===================================================================
--- net/base/ssl_client_socket_unittest.cc (revision 18649)
+++ net/base/ssl_client_socket_unittest.cc (working copy)
@@ -54,6 +54,18 @@
//-----------------------------------------------------------------------------
#if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, we choke at the point
+// SSLHandshake() (Security framework call) is called from
+// SSLClientSocketMac::DoHandshake(). Return value is -9812 (cert
+// valid but root not trusted), but if you don't have the cert in your
+// keychain as documented on
+// http://dev.chromium.org/developers/testing, the -9812 becomes a
wtc 2009/06/19 18:15:25 This seems to imply that after importing the test
+// -9813 (no root cert).
+//
+// See related handshake failures exhibited by disabled tests in
+// net/url_request/url_request_unittest.cc.
#define MAYBE_Connect DISABLED_Connect
#define MAYBE_ConnectExpired DISABLED_ConnectExpired
#define MAYBE_ConnectMismatched DISABLED_ConnectMismatched
« no previous file with comments | « no previous file | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698