Source/core/dom/MainThreadTaskRunner.cpp - Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MainThreadTaskRunner.cpp

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/MainThreadTaskRunner.cpp

diff --git a/Source/core/dom/MainThreadTaskRunner.cpp b/Source/core/dom/MainThreadTaskRunner.cpp

index 339332f5050456d486acedd6de1ea58f7448043e..58b45ab0306a35c4fc0da010a74589f8ef4887aa 100644

--- a/Source/core/dom/MainThreadTaskRunner.cpp

+++ b/Source/core/dom/MainThreadTaskRunner.cpp

@@ -48,11 +48,7 @@ public:

void run() override;

private:

-#if ENABLE(OILPAN)

- CrossThreadWeakPersistent<MainThreadTaskRunner> m_runner;

-#else

- WeakPtr<MainThreadTaskRunner> m_runner;

-#endif

+ WeakPtrWillBeCrossThreadWeakPersistent<MainThreadTaskRunner> m_runner;

OwnPtr<ExecutionContextTask> m_task;

bool m_isInspectorTask;

};