Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1319893004: Remove builtin/runtime name clash presubmit check. (Closed)

Created:
5 years, 3 months ago by Yang
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove builtin/runtime name clash presubmit check. It has become obsolete since we do the name lookup at compile time. R=bmeurer@chromium.org Committed: https://crrev.com/6bef1d0a134995d3136f83d6165a7007119a02c3 Cr-Commit-Position: refs/heads/master@{#30405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -131 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -4 lines 0 comments Download
M src/parser.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime.js View 2 chunks +6 lines, -2 lines 0 comments Download
D tools/check-name-clashes.py View 1 chunk +0 lines, -118 lines 0 comments Download
M tools/presubmit.py View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 3 months ago (2015-08-27 10:32:34 UTC) #1
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-08-27 10:33:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319893004/1
5 years, 3 months ago (2015-08-27 10:33:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 10:59:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319893004/1
5 years, 3 months ago (2015-08-27 11:12:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 11:14:01 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 11:14:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bef1d0a134995d3136f83d6165a7007119a02c3
Cr-Commit-Position: refs/heads/master@{#30405}

Powered by Google App Engine
This is Rietveld 408576698