| OLD | NEW |
| 1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 60 'not perfect. The commit queue will not block on this warning.') | 60 'not perfect. The commit queue will not block on this warning.') |
| 61 | 61 |
| 62 | 62 |
| 63 def _V8PresubmitChecks(input_api, output_api): | 63 def _V8PresubmitChecks(input_api, output_api): |
| 64 """Runs the V8 presubmit checks.""" | 64 """Runs the V8 presubmit checks.""" |
| 65 import sys | 65 import sys |
| 66 sys.path.append(input_api.os_path.join( | 66 sys.path.append(input_api.os_path.join( |
| 67 input_api.PresubmitLocalPath(), 'tools')) | 67 input_api.PresubmitLocalPath(), 'tools')) |
| 68 from presubmit import CppLintProcessor | 68 from presubmit import CppLintProcessor |
| 69 from presubmit import SourceProcessor | 69 from presubmit import SourceProcessor |
| 70 from presubmit import CheckRuntimeVsNativesNameClashes | |
| 71 from presubmit import CheckExternalReferenceRegistration | 70 from presubmit import CheckExternalReferenceRegistration |
| 72 from presubmit import CheckAuthorizedAuthor | 71 from presubmit import CheckAuthorizedAuthor |
| 73 | 72 |
| 74 results = [] | 73 results = [] |
| 75 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): | 74 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): |
| 76 results.append(output_api.PresubmitError("C++ lint check failed")) | 75 results.append(output_api.PresubmitError("C++ lint check failed")) |
| 77 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): | 76 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): |
| 78 results.append(output_api.PresubmitError( | 77 results.append(output_api.PresubmitError( |
| 79 "Copyright header, trailing whitespaces and two empty lines " \ | 78 "Copyright header, trailing whitespaces and two empty lines " \ |
| 80 "between declarations check failed")) | 79 "between declarations check failed")) |
| 81 if not CheckRuntimeVsNativesNameClashes(input_api.PresubmitLocalPath()): | |
| 82 results.append(output_api.PresubmitError( | |
| 83 "Runtime/natives name clash check failed")) | |
| 84 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): | 80 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): |
| 85 results.append(output_api.PresubmitError( | 81 results.append(output_api.PresubmitError( |
| 86 "External references registration check failed")) | 82 "External references registration check failed")) |
| 87 results.extend(CheckAuthorizedAuthor(input_api, output_api)) | 83 results.extend(CheckAuthorizedAuthor(input_api, output_api)) |
| 88 return results | 84 return results |
| 89 | 85 |
| 90 | 86 |
| 91 def _CheckUnwantedDependencies(input_api, output_api): | 87 def _CheckUnwantedDependencies(input_api, output_api): |
| 92 """Runs checkdeps on #include statements added in this | 88 """Runs checkdeps on #include statements added in this |
| 93 change. Breaking - rules is an error, breaking ! rules is a | 89 change. Breaking - rules is an error, breaking ! rules is a |
| (...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 295 'v8_win64_rel': set(['defaulttests']), | 291 'v8_win64_rel': set(['defaulttests']), |
| 296 'v8_mac_rel': set(['defaulttests']), | 292 'v8_mac_rel': set(['defaulttests']), |
| 297 'v8_linux_arm_rel': set(['defaulttests']), | 293 'v8_linux_arm_rel': set(['defaulttests']), |
| 298 'v8_linux_arm64_rel': set(['defaulttests']), | 294 'v8_linux_arm64_rel': set(['defaulttests']), |
| 299 'v8_linux_mipsel_compile_rel': set(['defaulttests']), | 295 'v8_linux_mipsel_compile_rel': set(['defaulttests']), |
| 300 'v8_linux_mips64el_compile_rel': set(['defaulttests']), | 296 'v8_linux_mips64el_compile_rel': set(['defaulttests']), |
| 301 'v8_android_arm_compile_rel': set(['defaulttests']), | 297 'v8_android_arm_compile_rel': set(['defaulttests']), |
| 302 'v8_linux_chromium_gn_rel': set(['defaulttests']), | 298 'v8_linux_chromium_gn_rel': set(['defaulttests']), |
| 303 }, | 299 }, |
| 304 } | 300 } |
| OLD | NEW |