Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 1319893004: Remove builtin/runtime name clash presubmit check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/check-name-clashes.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index a835e61792caad2f6858412c2263e0ce78fc2877..078a09ace7e77caa64195efbf4c7fe61336f92fb 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -438,12 +438,6 @@ class SourceProcessor(SourceFileProcessor):
return success
-def CheckRuntimeVsNativesNameClashes(workspace):
- code = subprocess.call(
- [sys.executable, join(workspace, "tools", "check-name-clashes.py")])
- return code == 0
-
-
def CheckExternalReferenceRegistration(workspace):
code = subprocess.call(
[sys.executable, join(workspace, "tools", "external-reference-check.py")])
@@ -495,7 +489,6 @@ def Main():
print "Running copyright header, trailing whitespaces and " \
"two empty lines between declarations check..."
success = SourceProcessor().Run(workspace) and success
- success = CheckRuntimeVsNativesNameClashes(workspace) and success
success = CheckExternalReferenceRegistration(workspace) and success
if success:
return 0
« no previous file with comments | « tools/check-name-clashes.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698