Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1319123004: Reland Vector ICs: platform support for vector-based stores. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Vector ICs: platform support for vector-based stores. The last changes for vector store functionality, they are in 3 areas: 1) The new vector [keyed] store code stubs - implementation. 2) IC and handler compiler adjustments 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. TBR=bmeurer@chromium.org, jkummerow@chromium.org BUG= Committed: https://crrev.com/40fbed0609ddb3e4ee4338049383004b62d13853 Cr-Commit-Position: refs/heads/master@{#30581}

Patch Set 1 #

Patch Set 2 : Fix for arm[64] release build failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1493 lines, -177 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +168 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +153 lines, -4 lines 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +300 lines, -2 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +19 lines, -8 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 3 chunks +17 lines, -7 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +19 lines, -9 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 3 chunks +9 lines, -7 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 5 chunks +31 lines, -12 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/ia32/ic-ia32.cc View 3 chunks +21 lines, -5 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 3 chunks +29 lines, -17 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +19 lines, -8 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +19 lines, -8 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 4 chunks +23 lines, -8 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +165 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +160 lines, -4 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +146 lines, -4 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +85 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mvstanton
Reland with fix for ARM and ARM64 release build failure. Thx, --Michael
5 years, 3 months ago (2015-09-04 08:12:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319123004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319123004/20001
5 years, 3 months ago (2015-09-04 08:12:35 UTC) #3
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-04 08:15:35 UTC) #4
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-04 08:23:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 08:36:35 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 08:36:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40fbed0609ddb3e4ee4338049383004b62d13853
Cr-Commit-Position: refs/heads/master@{#30581}

Powered by Google App Engine
This is Rietveld 408576698