src/ic/x64/ic-compiler-x64.cc - Issue 1319123004: Reland Vector ICs: platform support for vector-based stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/ic-compiler-x64.cc

Issue 1319123004: Reland Vector ICs: platform support for vector-based stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix for arm[64] release build failure. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/ic-compiler-x64.cc

diff --git a/src/ic/x64/ic-compiler-x64.cc b/src/ic/x64/ic-compiler-x64.cc

index d5e548412c8fbb2490fd34f8ad4a1ee4196be68a..fd92cca57023f18fe8701a267968d41225ead4be 100644

--- a/src/ic/x64/ic-compiler-x64.cc

+++ b/src/ic/x64/ic-compiler-x64.cc

@@ -55,7 +55,10 @@ Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(

Label next_map;

__ j(not_equal, &next_map, Label::kNear);

Handle<WeakCell> cell = Map::WeakCellForMap(transitioned_maps->at(i));

- __ LoadWeakValue(transition_map(), cell, &miss);

+ Register transition_map = scratch1();

+ DCHECK(!FLAG_vector_stores &&

+ transition_map.is(StoreTransitionDescriptor::MapRegister()));

+ __ LoadWeakValue(transition_map, cell, &miss);

__ jmp(handler_stubs->at(i), RelocInfo::CODE_TARGET);

__ bind(&next_map);

}

« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »