chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java - Issue 1318003005: Switch to using url bar hiding by default in customtabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

Issue 1318003005: Switch to using url bar hiding by default in customtabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

index 27266e0958e1b6dd2a7a20b3d926124104f6a3d4..9303af3b8e0089b5d53209236046b2f7856d1e2f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

@@ -100,7 +100,7 @@ public class CustomTabIntentDataProvider {

mSession = IntentUtils.safeGetBinderExtra(intent, CustomTabsIntent.EXTRA_SESSION);

retrieveToolbarColor(intent, context);

mEnableUrlBarHiding = IntentUtils.safeGetBooleanExtra(

- intent, CustomTabsIntent.EXTRA_ENABLE_URLBAR_HIDING, false);

+ intent, CustomTabsIntent.EXTRA_ENABLE_URLBAR_HIDING, true);

mKeepAliveServiceIntent = IntentUtils.safeGetParcelableExtra(intent, EXTRA_KEEP_ALIVE);

Bundle actionButtonBundle =

« no previous file with comments | « no previous file | no next file » | no next file with comments »