Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317913004: Devtools [LayoutEditor]: show selector info and highlight affected nodes (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cursor2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools [LayoutEditor]: show selector info and highlight affected nodes BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201681

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 12

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -14 lines) Patch
M Source/core/inspector/InspectorOverlayHost.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 1 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 13 chunks +51 lines, -12 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 6 chunks +120 lines, -2 lines 0 comments Download
M Source/web/InspectorOverlayImpl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 3 chunks +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1310533007 Patch 80001

Dependent Patchsets:

Issue 1308383007 Patch 20001
Issue 1305343003 Patch 1
Issue 1308383007 Patch 40001

Messages

Total messages: 14 (5 generated)
sergeyv
5 years, 3 months ago (2015-08-28 19:42:44 UTC) #2
dgozman
lgtm with comments https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode321 Source/core/inspector/LayoutEditor.cpp:321: m_matchedRules.clear(); Please also clear rules on ...
5 years, 3 months ago (2015-09-02 18:58:57 UTC) #3
sergeyv
https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode321 Source/core/inspector/LayoutEditor.cpp:321: m_matchedRules.clear(); On 2015/09/02 18:58:57, dgozman wrote: > Please also ...
5 years, 3 months ago (2015-09-02 20:22:18 UTC) #4
sergeyv
https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1317913004/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode321 Source/core/inspector/LayoutEditor.cpp:321: m_matchedRules.clear(); On 2015/09/02 18:58:57, dgozman wrote: > Please also ...
5 years, 3 months ago (2015-09-02 20:22:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317913004/40001
5 years, 3 months ago (2015-09-02 20:22:39 UTC) #7
pfeldman
lgtm
5 years, 3 months ago (2015-09-02 21:18:28 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 22:00:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317913004/40001
5 years, 3 months ago (2015-09-02 23:10:37 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 23:15:51 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201681

Powered by Google App Engine
This is Rietveld 408576698