Devtools [LayoutEditor]: Show medias for the rules with the same selectors

Devtools [LayoutEditor]: Show medias for the rules with the same selectors

BUG=501896
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201696

[sergeyv, 2015-08-28 19:43:02]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[sergeyv, 2015-08-28 19:43:03]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[dgozman, 2015-09-02 22:06:26]

lgtm

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorOverlayPage.html (right):

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorOverlayPage.html:838: tooltipElement.textContent
= (selectorInfo.medias ? selectorInfo.medias.join(", ") + " "  : "") +
selectorInfo.selector;
Add @media before each media.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
File Source/core/inspector/LayoutEditor.cpp (right):

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:405: hasSameSelectors |= i !=
static_cast<unsigned>(m_currentRuleIndex) && m_matchedRules[i]->selectorText()
== currentSelectorText;
if (i != ....)
   ...

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:456: PassOwnPtr<Vector<String>>
LayoutEditor::buildMediaListChain(CSSRule* rule)
Let's follow the pattern of (..., Vector<String>&).

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:456: PassOwnPtr<Vector<String>>
LayoutEditor::buildMediaListChain(CSSRule* rule)
Move to namespace.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:462: while (parentRule) {
s/parentRule/rule

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:468: while (styleSheet) {
TODO: should be able to replace cycle by one iteration of it.

[sergeyv, 2015-09-02 23:58:34]

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorOverlayPage.html (right):

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorOverlayPage.html:838: tooltipElement.textContent
= (selectorInfo.medias ? selectorInfo.medias.join(", ") + " "  : "") +
selectorInfo.selector;
On 2015/09/02 22:06:25, dgozman wrote:
> Add @media before each media.

Done.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
File Source/core/inspector/LayoutEditor.cpp (right):

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:405: hasSameSelectors |= i !=
static_cast<unsigned>(m_currentRuleIndex) && m_matchedRules[i]->selectorText()
== currentSelectorText;
On 2015/09/02 22:06:26, dgozman wrote:
> if (i != ....)
>    ...

Done.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:456: PassOwnPtr<Vector<String>>
LayoutEditor::buildMediaListChain(CSSRule* rule)
On 2015/09/02 22:06:25, dgozman wrote:
> Move to namespace.

Done.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:456: PassOwnPtr<Vector<String>>
LayoutEditor::buildMediaListChain(CSSRule* rule)
On 2015/09/02 22:06:26, dgozman wrote:
> Let's follow the pattern of (..., Vector<String>&).

Done.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:462: while (parentRule) {
On 2015/09/02 22:06:25, dgozman wrote:
> s/parentRule/rule

Done.

https://codereview.chromium.org/1308383007/diff/20001/Source/core/inspector/L...
Source/core/inspector/LayoutEditor.cpp:468: while (styleSheet) {
On 2015/09/02 22:06:25, dgozman wrote:
> TODO: should be able to replace cycle by one iteration of it.

Done.

[sergeyv, 2015-09-02 23:58:50]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-09-02 23:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1308383007/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-02 23:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308383007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308383007/40001

[commit-bot: I haz the power, 2015-09-03 01:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 01:14:27]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[sergeyv, 2015-09-03 01:30:13]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2015-09-03 01:30:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308383007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308383007/40001

[commit-bot: I haz the power, 2015-09-03 03:57:55]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201696