Changes around how embed roots are set

Changes around how embed roots are set

I'm adding a generic SetAccessPolicy function. The semantics are only the
owner can change the policy and the next ViewTreeClient that is
embedded in the view picks up the access policy. This way access
policies are locked to the life of the connection. The API also allows
us to add other policies in the future.

BUG=none
TEST=covered by tests
R=fsamuel@chromium.org

Committed: https://crrev.com/0b9dc8c54e1558554bd3e334dd8b45f0b68acc13
Cr-Commit-Position: refs/heads/master@{#347452}

[Fady Samuel, 2015-09-04 16:02:32]

LGTM + question, could the access policy be an enum instead of a set of
constants?

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
File components/view_manager/public/interfaces/view_tree.mojom (right):

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
components/view_manager/public/interfaces/view_tree.mojom:47: const uint32
kAccessPolicyDefault = 0;
Could this be an enum instead?

[sky, 2015-09-04 16:38:11]

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
File components/view_manager/public/interfaces/view_tree.mojom (right):

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
components/view_manager/public/interfaces/view_tree.mojom:47: const uint32
kAccessPolicyDefault = 0;
On 2015/09/04 16:02:32, Fady Samuel wrote:
> Could this be an enum instead?

As SetAccessPolicy is a bitmask it's a bit misleading to use an enum. See this
discussion:
https://groups.google.com/a/chromium.org/forum/#!searchin/mojo-dev/enum/mojo-...
. Although it's not clear if Trung actually removed support for enums with
explicit values.

[sky, 2015-09-04 16:41:44]

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
File components/view_manager/public/interfaces/view_tree.mojom (right):

https://codereview.chromium.org/1317713006/diff/20001/components/view_manager...
components/view_manager/public/interfaces/view_tree.mojom:47: const uint32
kAccessPolicyDefault = 0;
On 2015/09/04 16:38:11, sky wrote:
> On 2015/09/04 16:02:32, Fady Samuel wrote:
> > Could this be an enum instead?
> 
> As SetAccessPolicy is a bitmask it's a bit misleading to use an enum. See this
> discussion:
>
https://groups.google.com/a/chromium.org/forum/#!searchin/mojo-dev/enum/mojo-...
> . Although it's not clear if Trung actually removed support for enums with
> explicit values.

Actually, it looks like we still support explicit values. So I'll change this to
an enum.

[sky, 2015-09-04 17:09:37]

Changed to enum.

[sky, 2015-09-04 17:09:46]

The CQ bit was checked by sky@chromium.org

[sky, 2015-09-04 17:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1317713006/#ps40001
(title: "use enum")

[commit-bot: I haz the power, 2015-09-04 17:10:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317713006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317713006/40001

[commit-bot: I haz the power, 2015-09-04 17:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 17:12:47]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2015-09-04 17:41:59]

The CQ bit was checked by sky@chromium.org

[sky, 2015-09-04 17:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1317713006/#ps60001
(title: "merge to trunk")

[commit-bot: I haz the power, 2015-09-04 17:42:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317713006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317713006/60001

[commit-bot: I haz the power, 2015-09-04 18:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 18:12:04]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[sky, 2015-09-04 18:18:28]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-09-04 18:18:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317713006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317713006/60001

[commit-bot: I haz the power, 2015-09-04 18:44:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-04 18:46:02]

Patchset 4 (id:??) landed as
https://crrev.com/0b9dc8c54e1558554bd3e334dd8b45f0b68acc13
Cr-Commit-Position: refs/heads/master@{#347452}