components/web_view/web_view_impl.cc - Issue 1317713006: Changes around how embed roots are set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/web_view_impl.cc

Issue 1317713006: Changes around how embed roots are set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge to trunk Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_view/web_view_impl.cc

diff --git a/components/web_view/web_view_impl.cc b/components/web_view/web_view_impl.cc

index 322fcaefa468458497f891a802ff1c03e46803e1..e73058937ec679c22701d31446d6c1c148c9083c 100644

--- a/components/web_view/web_view_impl.cc

+++ b/components/web_view/web_view_impl.cc

@@ -92,7 +92,9 @@ void WebViewImpl::GetViewTreeClient(

// WebViewImpl, mojo::ViewTreeDelegate implementation:

void WebViewImpl::OnEmbed(mojo::View* root) {

- root->connection()->SetEmbedRoot();

+ // We must have been granted embed root priviledges, otherwise we can't

+ // Embed() in any descendants.

+ DCHECK(root->connection()->IsEmbedRoot());

root->AddObserver(this);

root_ = root;

content_ = root->connection()->CreateView();