Make the LayoutRect->FloatRect constructor explicit.

Make the LayoutRect->FloatRect constructor explicit.

In a couple of places, we now have a larger cull rect bound for drawing recorders
because of using enclosingIntRect. This is always safe to do.

BUG=524259
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201295

[chrishtr, 2015-08-26 18:31:33]

chrishtr@chromium.org changed reviewers:
+ eae@chromium.org, jbroman@chromium.org

[eae, 2015-08-26 18:37:20]

LGTM

[jbroman, 2015-08-26 19:06:44]

Reviewed the first part; a number of lines of code affected by the root concern:
I think it's fine for LayoutObjectDrawingRecorder to take its bounds as a
FloatRect. The code afterwards works in terms of floats anyhow, and anyone who
constructs a drawing recorder will presumably draw something -- and our drawing
commands are also (largely) in terms of floats.

A LayoutRect overload may be convenient for some callers, though.

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
File Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:687:
m_quads.append(m_geometryMap.absoluteRect(FloatRect(rect)));
nit: I don't feel strongly, but how about delegating to the existing method
which shares most of the logic:

void operator()(const LayoutRect& rect)
{
    operator()(FloatRect(rect));
}

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:863: m_rect.uniteIfNonZero(FloatRect(rect));
could do the same here; not sure if it's cleaner or not

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:1369: LayoutRect layoutRect(rect);
nit: and here, but delegating to the LayoutRect overload

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutTe...
File Source/core/layout/LayoutTextControlSingleLine.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutTe...
Source/core/layout/LayoutTextControlSingleLine.cpp:92:
LayoutObjectDrawingRecorder recorder(*paintInfo.context, *this, paintInfo.phase,
LayoutRect(snappedRect));
This is currently going via FloatRect(const IntRect&), not via LayoutRect. And
it happens that FloatRect is what DrawingRecorder ultimately wants. I happen to
think this implicit conversion is probably fine, but if you disagree, suggest
either making this cast to FloatRect instead, or adding an IntRect overload to
the LayoutObjectDrawingRecorder constructor.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/BoxPainte...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/BoxPainte...
Source/core/paint/BoxPainter.cpp:571: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutBox, paintInfo.phase,
LayoutRect(paintRect));
ditto (no need to go via LayoutRect)

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayer.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayer.cpp:2168: if (IntRect(result) ==
LayoutRect::infiniteIntRect()) {
I don't know what this method is doing right now, but currently this is not the
conversion that would have happened previously. Previously we would have
converted the IntRect to LayoutRect and used operator== on LayoutRects.

There's a loss of precision in the LayoutRect->IntRect conversion; if you intend
to make this functional change, I'd rather it be a separate CL where it's not
mixed in with mechanical changes.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FieldsetP...
File Source/core/paint/FieldsetPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FieldsetP...
Source/core/paint/FieldsetPainter.cpp:44: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase,
LayoutRect(pixelSnappedIntRect(paintRect)));
as before, this is currently an IntRect->FloatRect conversion; LayoutRect isn't
involved

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FileUploa...
File Source/core/paint/FileUploadControlPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FileUploa...
Source/core/paint/FileUploadControlPainter.cpp:70: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase,
LayoutRect(enclosingIntRect(textRunPaintInfo.bounds)));
ditto

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.cpp:169: LayoutObjectDrawingRecorder
drawingRecorder(*context, *frameView().layoutView(),
DisplayItem::ScrollbarCorner, LayoutRect(cornerRect));
ditto: no need to go via LayoutRect

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
File Source/core/paint/ImagePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
Source/core/paint/ImagePainter.cpp:65: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutImage, paintInfo.phase,
LayoutRect(focusRect));
ditto

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
Source/core/paint/ImagePainter.cpp:93: LayoutObjectDrawingRecorder
drawingRecorder(*context, m_layoutImage, paintInfo.phase,
LayoutRect(paintRect));
ditto

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayerClip...
File Source/core/paint/LayerClipRecorderTest.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayerClip...
Source/core/paint/LayerClipRecorderTest.cpp:58: void
drawRectInClip(GraphicsContext& context, LayoutView& layoutView, PaintPhase
phase, const LayoutRect& bound)
Unsure, but maybe I think should stay FloatRect; why would you like to change
it?

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:34:
LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject&
layoutObject, DisplayItem::Type displayItemType, const LayoutRect& clip)
This is the root cause of a bunch of my other comments, but I think this should
probably stay FloatRect (possibly with a LayoutRect overload if the implicit
conversion is going away, for convenience).

There are many call sites where we have an IntRect or FloatRect already, both of
which can be more cheaply and safely converted directly to FloatRect, and floats
are generally the unit from this point in the stack on.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorderTest.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorderTest.cpp:53: void
drawNothing(GraphicsContext& context, const LayoutView& layoutView, PaintPhase
phase, const LayoutRect& bound)
same line of reasoning here

[chrishtr, 2015-08-26 20:53:52]

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
File Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:687:
m_quads.append(m_geometryMap.absoluteRect(FloatRect(rect)));
On 2015/08/26 at 19:06:43, jbroman wrote:
> nit: I don't feel strongly, but how about delegating to the existing method
which shares most of the logic:
> 
> void operator()(const LayoutRect& rect)
> {
>     operator()(FloatRect(rect));
> }

Done.

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:863: m_rect.uniteIfNonZero(FloatRect(rect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> could do the same here; not sure if it's cleaner or not

Done.

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutIn...
Source/core/layout/LayoutInline.cpp:1369: LayoutRect layoutRect(rect);
On 2015/08/26 at 19:06:43, jbroman wrote:
> nit: and here, but delegating to the LayoutRect overload

Done.

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutTe...
File Source/core/layout/LayoutTextControlSingleLine.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/layout/LayoutTe...
Source/core/layout/LayoutTextControlSingleLine.cpp:92:
LayoutObjectDrawingRecorder recorder(*paintInfo.context, *this, paintInfo.phase,
LayoutRect(snappedRect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> This is currently going via FloatRect(const IntRect&), not via LayoutRect. And
it happens that FloatRect is what DrawingRecorder ultimately wants. I happen to
think this implicit conversion is probably fine, but if you disagree, suggest
either making this cast to FloatRect instead, or adding an IntRect overload to
the LayoutObjectDrawingRecorder constructor.

Reverted.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/BoxPainte...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/BoxPainte...
Source/core/paint/BoxPainter.cpp:571: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutBox, paintInfo.phase,
LayoutRect(paintRect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> ditto (no need to go via LayoutRect)

Reverted.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayer.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayer.cpp:2168: if (IntRect(result) ==
LayoutRect::infiniteIntRect()) {
On 2015/08/26 at 19:06:43, jbroman wrote:
> I don't know what this method is doing right now, but currently this is not
the conversion that would have happened previously. Previously we would have
converted the IntRect to LayoutRect and used operator== on LayoutRects.
> 
> There's a loss of precision in the LayoutRect->IntRect conversion; if you
intend to make this functional change, I'd rather it be a separate CL where it's
not mixed in with mechanical changes.

Fixed this, and the one I already committed that was in
https://codereview.chromium.org/1303413004.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FileUploa...
File Source/core/paint/FileUploadControlPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FileUploa...
Source/core/paint/FileUploadControlPainter.cpp:70: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase,
LayoutRect(enclosingIntRect(textRunPaintInfo.bounds)));
On 2015/08/26 at 19:06:43, jbroman wrote:
> ditto

Reverted.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.cpp:169: LayoutObjectDrawingRecorder
drawingRecorder(*context, *frameView().layoutView(),
DisplayItem::ScrollbarCorner, LayoutRect(cornerRect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> ditto: no need to go via LayoutRect

Fixed.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
File Source/core/paint/ImagePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
Source/core/paint/ImagePainter.cpp:65: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutImage, paintInfo.phase,
LayoutRect(focusRect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> ditto

Fixed.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/ImagePain...
Source/core/paint/ImagePainter.cpp:93: LayoutObjectDrawingRecorder
drawingRecorder(*context, m_layoutImage, paintInfo.phase,
LayoutRect(paintRect));
On 2015/08/26 at 19:06:43, jbroman wrote:
> ditto

Fixed.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayerClip...
File Source/core/paint/LayerClipRecorderTest.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayerClip...
Source/core/paint/LayerClipRecorderTest.cpp:58: void
drawRectInClip(GraphicsContext& context, LayoutView& layoutView, PaintPhase
phase, const LayoutRect& bound)
On 2015/08/26 at 19:06:43, jbroman wrote:
> Unsure, but maybe I think should stay FloatRect; why would you like to change
it?

Same reply as for other test.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:34:
LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject&
layoutObject, DisplayItem::Type displayItemType, const LayoutRect& clip)
On 2015/08/26 at 19:06:43, jbroman wrote:
> This is the root cause of a bunch of my other comments, but I think this
should probably stay FloatRect (possibly with a LayoutRect overload if the
implicit conversion is going away, for convenience).
> 
> There are many call sites where we have an IntRect or FloatRect already, both
of which can be more cheaply and safely converted directly to FloatRect, and
floats are generally the unit from this point in the stack on.

Done.

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorderTest.cpp (right):

https://codereview.chromium.org/1316163002/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorderTest.cpp:53: void
drawNothing(GraphicsContext& context, const LayoutView& layoutView, PaintPhase
phase, const LayoutRect& bound)
On 2015/08/26 at 19:06:44, jbroman wrote:
> same line of reasoning here

Left it LayoutRect because layoutView().viewRect() returns a LayoutRect.

[jbroman, 2015-08-26 21:45:09]

lgtm

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Embed...
File Source/core/paint/EmbeddedObjectPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Embed...
Source/core/paint/EmbeddedObjectPainter.cpp:52: LayoutObjectDrawingRecorder
drawingRecorder(*context, m_layoutEmbeddedObject, paintInfo.phase,
LayoutRect(enclosingIntRect(contentRect)));
Can just use the IntRect overload to take enclosingIntRect.

(I haven't looked enough at EmbeddedObjectPainter (or some of these other
places) to know whether enclosingIntRect is necessary here, but it's safe to
add, so seems fine.)

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/FileU...
File Source/core/paint/FileUploadControlPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/FileU...
Source/core/paint/FileUploadControlPainter.cpp:70: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase,
LayoutRect(enclosingIntRect(textRunPaintInfo.bounds)));
ditto (no need for LayoutRect conversion)

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ListM...
File Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ListM...
Source/core/paint/ListMarkerPainter.cpp:42: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutListMarker, paintInfo.phase,
LayoutRect(pixelSnappedOverflowRect));
this can use the IntRect overload you added, no need for a conversion

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Objec...
File Source/core/paint/ObjectPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Objec...
Source/core/paint/ObjectPainter.cpp:90: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutObject,
DisplayItem::PrintedContentPDFURLRect, LayoutRect(rect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/PartP...
File Source/core/paint/PartPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/PartP...
Source/core/paint/PartPainter.cpp:70: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutPart, paintInfo.phase,
LayoutRect(selectionRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Repla...
File Source/core/paint/ReplacedPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Repla...
Source/core/paint/ReplacedPainter.cpp:97: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutReplaced,
DisplayItem::SelectionTint, LayoutRect(selectionPaintingIntRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGCl...
File Source/core/paint/SVGClipPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGCl...
Source/core/paint/SVGClipPainter.cpp:137: LayoutObjectDrawingRecorder
drawingRecorder(*context, layoutObject, DisplayItem::SVGClip,
LayoutRect(enclosingIntRect(targetPaintInvalidationRect)));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
File Source/core/paint/SVGFilterPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
Source/core/paint/SVGFilterPainter.cpp:190: LayoutObjectDrawingRecorder
recorder(*context, object, DisplayItem::SVGFilter,
LayoutRect(LayoutRect::infiniteIntRect()));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGIm...
File Source/core/paint/SVGImagePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGIm...
Source/core/paint/SVGImagePainter.cpp:40: LayoutObjectDrawingRecorder
recorder(*paintContext.paintInfo().context, m_layoutSVGImage,
paintContext.paintInfo().phase, LayoutRect(enclosingIntRect(boundingBox)));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGRo...
File Source/core/paint/SVGRootInlineBoxPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGRo...
Source/core/paint/SVGRootInlineBoxPainter.cpp:28: LayoutObjectDrawingRecorder
recorder(*paintInfoBeforeFiltering.context, m_svgRootInlineBox.layoutObject(),
paintInfoBeforeFiltering.phase, LayoutRect(paintInfoBeforeFiltering.rect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGSh...
File Source/core/paint/SVGShapePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGSh...
Source/core/paint/SVGShapePainter.cpp:63: LayoutObjectDrawingRecorder
recorder(*paintContext.paintInfo().context, m_layoutSVGShape,
paintContext.paintInfo().phase, LayoutRect(enclosingIntRect(boundingBox)));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
File Source/core/paint/ScrollableAreaPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
Source/core/paint/ScrollableAreaPainter.cpp:43: LayoutObjectDrawingRecorder
recorder(*context, scrollableArea().box(), DisplayItem::Resizer,
LayoutRect(absRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
Source/core/paint/ScrollableAreaPainter.cpp:198: LayoutObjectDrawingRecorder
recorder(*context, scrollableArea().box(), DisplayItem::ScrollbarCorner,
LayoutRect(absRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
File Source/core/paint/TableCellPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
Source/core/paint/TableCellPainter.cpp:118: LayoutObjectDrawingRecorder
recorder(*graphicsContext, m_layoutTableCell,
static_cast<DisplayItem::Type>(displayItemType), FloatRect(borderRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
Source/core/paint/TableCellPainter.cpp:196: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutTableCell,
DisplayItem::BoxDecorationBackground,
FloatRect(pixelSnappedIntRect(visualOverflowRect)));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ViewP...
File Source/core/paint/ViewPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ViewP...
Source/core/paint/ViewPainter.cpp:65: LayoutObjectDrawingRecorder
recorder(context, m_layoutView, DisplayItem::BoxDecorationBackground,
LayoutRect(documentRect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
File Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
Source/web/WebPluginContainerImpl.cpp:124: LayoutObjectDrawingRecorder
drawingRecorder(*context, *m_element->layoutObject(),
DisplayItem::Type::WebPlugin, LayoutRect(rect));
ditto

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
Source/web/WebPluginContainerImpl.cpp:348: LayoutObjectDrawingRecorder
drawingRecorder(*gc, *m_element->layoutObject(), DisplayItem::Type::WebPlugin,
LayoutRect(printRect));
ditto

[jbroman, 2015-08-26 21:45:11]

lgtm

[jbroman, 2015-08-26 21:46:24]

On 2015/08/26 at 21:45:11, jbroman wrote:
> lgtm

(Why'd I get two messages? Anyhow, looks good once the remaining
IntRect->LayoutRect->FloatRect conversions are removed, mostly/all by just using
IntRect overload for LayoutObjectDrawingRecorder constructor.)

[chrishtr, 2015-08-26 22:32:22]

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Embed...
File Source/core/paint/EmbeddedObjectPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Embed...
Source/core/paint/EmbeddedObjectPainter.cpp:52: LayoutObjectDrawingRecorder
drawingRecorder(*context, m_layoutEmbeddedObject, paintInfo.phase,
LayoutRect(enclosingIntRect(contentRect)));
On 2015/08/26 at 21:45:08, jbroman wrote:
> Can just use the IntRect overload to take enclosingIntRect.
> 
> (I haven't looked enough at EmbeddedObjectPainter (or some of these other
places) to know whether enclosingIntRect is necessary here, but it's safe to
add, so seems fine.)

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/FileU...
File Source/core/paint/FileUploadControlPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/FileU...
Source/core/paint/FileUploadControlPainter.cpp:70: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase,
LayoutRect(enclosingIntRect(textRunPaintInfo.bounds)));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto (no need for LayoutRect conversion)

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ListM...
File Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ListM...
Source/core/paint/ListMarkerPainter.cpp:42: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutListMarker, paintInfo.phase,
LayoutRect(pixelSnappedOverflowRect));
On 2015/08/26 at 21:45:08, jbroman wrote:
> this can use the IntRect overload you added, no need for a conversion

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Objec...
File Source/core/paint/ObjectPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Objec...
Source/core/paint/ObjectPainter.cpp:90: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutObject,
DisplayItem::PrintedContentPDFURLRect, LayoutRect(rect));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/PartP...
File Source/core/paint/PartPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/PartP...
Source/core/paint/PartPainter.cpp:70: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutPart, paintInfo.phase,
LayoutRect(selectionRect));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Repla...
File Source/core/paint/ReplacedPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Repla...
Source/core/paint/ReplacedPainter.cpp:97: LayoutObjectDrawingRecorder
drawingRecorder(*paintInfo.context, m_layoutReplaced,
DisplayItem::SelectionTint, LayoutRect(selectionPaintingIntRect));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGCl...
File Source/core/paint/SVGClipPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGCl...
Source/core/paint/SVGClipPainter.cpp:137: LayoutObjectDrawingRecorder
drawingRecorder(*context, layoutObject, DisplayItem::SVGClip,
LayoutRect(enclosingIntRect(targetPaintInvalidationRect)));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
File Source/core/paint/SVGFilterPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
Source/core/paint/SVGFilterPainter.cpp:190: LayoutObjectDrawingRecorder
recorder(*context, object, DisplayItem::SVGFilter,
LayoutRect(LayoutRect::infiniteIntRect()));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

No constructor convenience of this type.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGIm...
File Source/core/paint/SVGImagePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGIm...
Source/core/paint/SVGImagePainter.cpp:40: LayoutObjectDrawingRecorder
recorder(*paintContext.paintInfo().context, m_layoutSVGImage,
paintContext.paintInfo().phase, LayoutRect(enclosingIntRect(boundingBox)));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGRo...
File Source/core/paint/SVGRootInlineBoxPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGRo...
Source/core/paint/SVGRootInlineBoxPainter.cpp:28: LayoutObjectDrawingRecorder
recorder(*paintInfoBeforeFiltering.context, m_svgRootInlineBox.layoutObject(),
paintInfoBeforeFiltering.phase, LayoutRect(paintInfoBeforeFiltering.rect));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGSh...
File Source/core/paint/SVGShapePainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGSh...
Source/core/paint/SVGShapePainter.cpp:63: LayoutObjectDrawingRecorder
recorder(*paintContext.paintInfo().context, m_layoutSVGShape,
paintContext.paintInfo().phase, LayoutRect(enclosingIntRect(boundingBox)));
On 2015/08/26 at 21:45:08, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
File Source/core/paint/ScrollableAreaPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
Source/core/paint/ScrollableAreaPainter.cpp:43: LayoutObjectDrawingRecorder
recorder(*context, scrollableArea().box(), DisplayItem::Resizer,
LayoutRect(absRect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Scrol...
Source/core/paint/ScrollableAreaPainter.cpp:198: LayoutObjectDrawingRecorder
recorder(*context, scrollableArea().box(), DisplayItem::ScrollbarCorner,
LayoutRect(absRect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done.

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
File Source/core/paint/TableCellPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
Source/core/paint/TableCellPainter.cpp:118: LayoutObjectDrawingRecorder
recorder(*graphicsContext, m_layoutTableCell,
static_cast<DisplayItem::Type>(displayItemType), FloatRect(borderRect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/Table...
Source/core/paint/TableCellPainter.cpp:196: LayoutObjectDrawingRecorder
recorder(*paintInfo.context, m_layoutTableCell,
DisplayItem::BoxDecorationBackground,
FloatRect(pixelSnappedIntRect(visualOverflowRect)));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ViewP...
File Source/core/paint/ViewPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/ViewP...
Source/core/paint/ViewPainter.cpp:65: LayoutObjectDrawingRecorder
recorder(context, m_layoutView, DisplayItem::BoxDecorationBackground,
LayoutRect(documentRect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
File Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
Source/web/WebPluginContainerImpl.cpp:124: LayoutObjectDrawingRecorder
drawingRecorder(*context, *m_element->layoutObject(),
DisplayItem::Type::WebPlugin, LayoutRect(rect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done

https://codereview.chromium.org/1316163002/diff/20001/Source/web/WebPluginCon...
Source/web/WebPluginContainerImpl.cpp:348: LayoutObjectDrawingRecorder
drawingRecorder(*gc, *m_element->layoutObject(), DisplayItem::Type::WebPlugin,
LayoutRect(printRect));
On 2015/08/26 at 21:45:09, jbroman wrote:
> ditto

Done

[jbroman, 2015-08-26 22:33:55]

lgtm

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
File Source/core/paint/SVGFilterPainter.cpp (right):

https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
Source/core/paint/SVGFilterPainter.cpp:190: LayoutObjectDrawingRecorder
recorder(*context, object, DisplayItem::SVGFilter,
LayoutRect(LayoutRect::infiniteIntRect()));
On 2015/08/26 at 22:32:21, chrishtr wrote:
> On 2015/08/26 at 21:45:08, jbroman wrote:
> > ditto
> 
> No constructor convenience of this type.

If it's not worth adding one, suggest letting the implicit conversion do the
work, or do an explicit conversion to FloatRect instead of LayoutRect?

[chrishtr, 2015-08-26 22:37:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-08-26 22:37:05]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1316163002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-26 22:37:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316163002/40001

[chrishtr, 2015-08-26 22:37:57]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2015-08-26 22:41:27]

On 2015/08/26 at 22:33:55, jbroman wrote:
> lgtm
> 
>
https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
> File Source/core/paint/SVGFilterPainter.cpp (right):
> 
>
https://codereview.chromium.org/1316163002/diff/20001/Source/core/paint/SVGFi...
> Source/core/paint/SVGFilterPainter.cpp:190: LayoutObjectDrawingRecorder
recorder(*context, object, DisplayItem::SVGFilter,
LayoutRect(LayoutRect::infiniteIntRect()));
> On 2015/08/26 at 22:32:21, chrishtr wrote:
> > On 2015/08/26 at 21:45:08, jbroman wrote:
> > > ditto
> > 
> > No constructor convenience of this type.
> 
> If it's not worth adding one, suggest letting the implicit conversion do the
work, or do an explicit conversion to FloatRect instead of LayoutRect?

I did that elsewhere, just forgot to update this one. Done.

[chrishtr, 2015-08-26 22:41:30]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-08-26 22:41:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1316163002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-08-26 22:41:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316163002/60001

[commit-bot: I haz the power, 2015-08-26 23:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 23:05:55]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[chrishtr, 2015-08-26 23:24:20]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-08-26 23:24:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1316163002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-26 23:24:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316163002/80001

[commit-bot: I haz the power, 2015-08-27 00:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 00:51:23]

Failed to apply patch for Source/core/paint/DeprecatedPaintLayerPainter.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/paint/DeprecatedPaintLayerPainter.cpp
  Hunk #2 FAILED at 146.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/paint/DeprecatedPaintLayerPainter.cpp.rej

Patch:       Source/core/paint/DeprecatedPaintLayerPainter.cpp
Index: Source/core/paint/DeprecatedPaintLayerPainter.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerPainter.cpp
b/Source/core/paint/DeprecatedPaintLayerPainter.cpp
index
2f5156751e7f103a59518343cbc82251c37479d3..589e54ccd43a01ac320c807a8c53a625e862b87c
100644
--- a/Source/core/paint/DeprecatedPaintLayerPainter.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerPainter.cpp
@@ -132,7 +132,7 @@ public:
                     rootRelativeBounds =
paintLayer.physicalBoundingBoxIncludingReflectionAndStackingChildren(paintingInfo.rootLayer,
offsetFromRoot);
                     rootRelativeBoundsComputed = true;
                 }
-                m_clipPathRecorder.emplace(*context,
*paintLayer.layoutObject(), clipPath->path(rootRelativeBounds));
+                m_clipPathRecorder.emplace(*context,
*paintLayer.layoutObject(), clipPath->path(FloatRect(rootRelativeBounds)));
             }
         } else if (style.clipPath()->type() == ClipPathOperation::REFERENCE) {
             ReferenceClipPathOperation* referenceClipPathOperation =
toReferenceClipPathOperation(style.clipPath());
@@ -146,8 +146,8 @@ public:
                 }
 
                 m_resourceClipper =
toLayoutSVGResourceClipper(toLayoutSVGResourceContainer(element->layoutObject()));
-                if
(!SVGClipPainter(*m_resourceClipper).applyClippingToContext(*paintLayer.layoutObject(),
rootRelativeBounds,
-                    paintingInfo.paintDirtyRect, context, m_clipperState)) {
+                if
(!SVGClipPainter(*m_resourceClipper).applyClippingToContext(*paintLayer.layoutObject(),
FloatRect(rootRelativeBounds),
+                    FloatRect(paintingInfo.paintDirtyRect), context,
m_clipperState)) {
                     // No need to post-apply the clipper if this failed.
                     m_resourceClipper = 0;
                 }

[commit-bot: I haz the power, 2015-08-27 00:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[chrishtr, 2015-08-27 04:32:25]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-08-27 04:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1316163002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-08-27 04:32:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316163002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316163002/100001

[commit-bot: I haz the power, 2015-08-27 07:55:22]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201295