Make the LayoutRect->FloatRect constructor explicit.

Source/core/paint/DeprecatedPaintLayer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 1543 matching lines @@
 {
     RefPtr<HitTestingTransformState> transformState;
     LayoutPoint offset;
     if (containerTransformState) {
         // If we're already computing transform state, then it's relative to the container (which we know is non-null).
         transformState = HitTestingTransformState::create(*containerTransformState);
         convertToLayerCoords(containerLayer, offset);
     } else {
         // If this is the first time we need to make transform state, then base it off of hitTestLocation,
         // which is relative to rootLayer.
-        transformState = HitTestingTransformState::create(hitTestLocation.transformedPoint(), hitTestLocation.transformedRect(), FloatQuad(hitTestRect));
+        transformState = HitTestingTransformState::create(hitTestLocation.transformedPoint(), hitTestLocation.transformedRect(), FloatQuad(FloatRect(hitTestRect)));
         convertToLayerCoords(rootLayer, offset);
     }
     offset.moveBy(translationOffset);
 
     LayoutObject* containerLayoutObject = containerLayer ? containerLayer->layoutObject() : 0;
     if (layoutObject()->shouldUseTransformFromContainer(containerLayoutObject)) {
         TransformationMatrix containerTransform;
         layoutObject()->getTransformFromContainer(containerLayoutObject, toLayoutSize(offset), containerTransform);
         transformState->applyTransform(containerTransform, HitTestingTransformState::AccumulateTransform);
     } else {
@@ skipping 583 matching lines @@
     if (isRootLayer())
         return LayoutRect(m_layoutObject->view()->unscaledDocumentRect());
 
     // The layer created for the LayoutFlowThread is just a helper for painting and hit-testing,
     // and should not contribute to the bounding box. The LayoutMultiColumnSets will contribute
     // the correct size for the layout content of the multicol container.
     if (layoutObject()->isLayoutFlowThread())
         return LayoutRect();
 
     LayoutRect result = clipper().localClipRect();
-    if (result == LayoutRect::infiniteIntRect()) {
+    if (IntRect(result) == LayoutRect::infiniteIntRect()) {

[jbroman, 2015/08/26 19:06:43]

I don't know what this method is doing right now, but currently this is not the
conversion that would have happened previously. Previously we would have
converted the IntRect to LayoutRect and used operator== on LayoutRects.

There's a loss of precision in the LayoutRect->IntRect conversion; if you intend
to make this functional change, I'd rather it be a separate CL where it's not
mixed in with mechanical changes.

[chrishtr, 2015/08/26 20:53:51]

Fixed this, and the one I already committed that was in
https://codereview.chromium.org/1303413004.

         LayoutPoint origin;
         result = physicalBoundingBox(ancestorLayer, &origin);
 
         const_cast<DeprecatedPaintLayer*>(this)->stackingNode()->updateLayerListsIfNeeded();
 
         // Reflections are implemented with Layers that hang off of the reflected layer. However,
         // the reflection layer subtree does not include the subtree of the parent Layer, so
         // a recursive computation of stacking children yields no results. This breaks cases when there are stacking
         // children of the parent, that need to be included in reflected composited bounds.
         // Fix this by including composited bounds of stacking children of the reflected Layer.
@@ skipping 492 matching lines @@
 
 void showLayerTree(const blink::LayoutObject* layoutObject)
 {
     if (!layoutObject) {
         fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
         return;
     }
     showLayerTree(layoutObject->enclosingLayer());
 }
 #endif