Make the LayoutRect->FloatRect constructor explicit.

Source/core/layout/LayoutTextControlSingleLine.cpp

 /**
  * Copyright (C) 2006, 2007, 2010 Apple Inc. All rights reserved.
  *           (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 71 matching lines @@
 
         // Center in the block progression direction.
         if (isHorizontalWritingMode())
             contentsRect.setY((size().height() - contentsRect.height()) / 2);
         else
             contentsRect.setX((size().width() - contentsRect.width()) / 2);
 
         // Convert the rect into the coords used for painting the content
         contentsRect.moveBy(paintOffset + location());
         IntRect snappedRect = pixelSnappedIntRect(contentsRect);
-        LayoutObjectDrawingRecorder recorder(*paintInfo.context, *this, paintInfo.phase, snappedRect);
+        LayoutObjectDrawingRecorder recorder(*paintInfo.context, *this, paintInfo.phase, LayoutRect(snappedRect));

[jbroman, 2015/08/26 19:06:43]

This is currently going via FloatRect(const IntRect&), not via LayoutRect. And
it happens that FloatRect is what DrawingRecorder ultimately wants. I happen to
think this implicit conversion is probably fine, but if you disagree, suggest
either making this cast to FloatRect instead, or adding an IntRect overload to
the LayoutObjectDrawingRecorder constructor.

[chrishtr, 2015/08/26 20:53:51]

Reverted.

         LayoutTheme::theme().painter().paintCapsLockIndicator(this, paintInfo, snappedRect);
     }
 }
 
 LayoutUnit LayoutTextControlSingleLine::computeLogicalHeightLimit() const
 {
     return containerElement() ? contentLogicalHeight() : logicalHeight();
 }
 
 void LayoutTextControlSingleLine::layout()
@@ skipping 342 matching lines @@
     if (innerEditorElement())
         innerEditorElement()->setScrollTop(newTop);
 }
 
 HTMLInputElement* LayoutTextControlSingleLine::inputElement() const
 {
     return toHTMLInputElement(node());
 }
 
 }