Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants. (Closed)

Created:
5 years, 3 months ago by vivekg_samsung
Modified:
5 years, 3 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Bindings should only support the prescribed types for constants. Specification at https://heycam.github.io/webidl/#idl-constants mentions the constants should be defined as: const type identifier = value; whereas the |type| is mentioned as: The type of a constant (matching ConstType) must not be any type other than a primitive type or a nullable primitive type And string literals are not treated as primitive types. Hence we should remove the support for having a constant like: const DOMString hello = "world"; BUG=469961 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -47 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/templates/constants.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +24 lines, -25 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
vivekg
The usage of DOMString as constant is treated as error in FF as per [1] ...
5 years, 3 months ago (2015-08-26 13:47:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315663004/1
5 years, 3 months ago (2015-08-26 13:50:27 UTC) #4
haraken
LGTM
5 years, 3 months ago (2015-08-26 23:22:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315663004/1
5 years, 3 months ago (2015-08-27 00:29:57 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 02:31:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201278

Powered by Google App Engine
This is Rietveld 408576698