Source/bindings/tests/results/core/V8TestException.cpp - Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestException.cpp

Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/core/V8TestException.cpp

diff --git a/Source/bindings/tests/results/core/V8TestException.cpp b/Source/bindings/tests/results/core/V8TestException.cpp

index e77d945f83034bb59314518df3447001e5a6a343..427ee2c4b984723827741957599c2006b1834879 100644

--- a/Source/bindings/tests/results/core/V8TestException.cpp

+++ b/Source/bindings/tests/results/core/V8TestException.cpp

@@ -138,7 +138,7 @@ static void installV8TestExceptionTemplate(v8::Local<v8::FunctionTemplate> funct

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

static const V8DOMConfiguration::ConstantConfiguration V8TestExceptionConstants[] = {

- {"UNSIGNED_SHORT_CONSTANT", 1, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},

+ {"UNSIGNED_SHORT_CONSTANT", 1, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},

};

V8DOMConfiguration::installConstants(isolate, functionTemplate, prototypeTemplate, V8TestExceptionConstants, WTF_ARRAY_LENGTH(V8TestExceptionConstants));

const V8DOMConfiguration::MethodConfiguration toStringMethodConfiguration = {

« no previous file with comments | « Source/bindings/tests/idls/core/TestObject.idl ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »