Source/bindings/tests/results/modules/V8TestInterface5.cpp - Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/modules/V8TestInterface5.cpp

diff --git a/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

index d6b8bf6d86bdbddbbd20c7fc4eb4d65ca157adcf..c744db8e26e6d6b2a67f05db6cb459549453b74a 100644

--- a/Source/bindings/tests/results/modules/V8TestInterface5.cpp

+++ b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

@@ -970,8 +970,8 @@ static void installV8TestInterface5Template(v8::Local<v8::FunctionTemplate> func

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

static const V8DOMConfiguration::ConstantConfiguration V8TestInterface5Constants[] = {

- {"UNSIGNED_LONG", 0, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedLong},

- {"CONST_JAVASCRIPT", 1, 0, 0, V8DOMConfiguration::ConstantTypeShort},

+ {"UNSIGNED_LONG", 0, 0, V8DOMConfiguration::ConstantTypeUnsignedLong},

+ {"CONST_JAVASCRIPT", 1, 0, V8DOMConfiguration::ConstantTypeShort},

};

V8DOMConfiguration::installConstants(isolate, functionTemplate, prototypeTemplate, V8TestInterface5Constants, WTF_ARRAY_LENGTH(V8TestInterface5Constants));

{