Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315563003: GrPathRangeBatch (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : working #

Patch Set 4 : small #

Patch Set 5 : more #

Total comments: 1

Patch Set 6 : remove unused function #

Patch Set 7 : fix windows style slash #

Patch Set 8 : fix init order warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -589 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 chunks +7 lines, -12 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.h View 1 2 chunks +0 lines, -69 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 2 chunks +2 lines, -60 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 1 chunk +6 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 5 chunks +15 lines, -31 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 4 chunks +18 lines, -66 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 2 3 4 5 2 chunks +0 lines, -75 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 2 3 4 5 6 7 4 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 2 3 4 5 6 7 8 chunks +39 lines, -39 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 chunks +0 lines, -84 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 2 3 4 1 chunk +136 lines, -34 lines 0 comments Download
A src/gpu/batches/GrDrawPathBatch.cpp View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
bsalomon
5 years, 3 months ago (2015-09-08 23:10:59 UTC) #2
joshualitt
lgtm https://codereview.chromium.org/1315563003/diff/80001/src/gpu/batches/GrDrawPathBatch.cpp File src/gpu/batches/GrDrawPathBatch.cpp (right): https://codereview.chromium.org/1315563003/diff/80001/src/gpu/batches/GrDrawPathBatch.cpp#newcode67 src/gpu/batches/GrDrawPathBatch.cpp:67: fBounds.setLargest(); this does mean no out of order ...
5 years, 3 months ago (2015-09-09 13:44:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315563003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315563003/80001
5 years, 3 months ago (2015-09-09 14:40:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3153)
5 years, 3 months ago (2015-09-09 14:41:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315563003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315563003/100001
5 years, 3 months ago (2015-09-09 15:22:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3157)
5 years, 3 months ago (2015-09-09 15:23:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315563003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315563003/120001
5 years, 3 months ago (2015-09-09 15:30:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3159)
5 years, 3 months ago (2015-09-09 15:32:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315563003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315563003/140001
5 years, 3 months ago (2015-09-09 16:42:19 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 16:48:09 UTC) #21
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/1fcc01c4158bd68c679569e6c7cfbb302d0ce170

Powered by Google App Engine
This is Rietveld 408576698